RuboCop Quest Issue about faraday_middleware

[olleolleolle]

Thank you, everyone! I am declaring a victory: there are now AbcSize + MethodLength left, and those are just set in the TODO file to a current "max" value which we can prune downwards as we go.

This was a significant piece of formatting - thanks so much for stepping up and helping out with this. A special round of applause for @onk and @d-m-u who picked up the bulk of the pieces left after @iMacTia did the initial automated push.

Closing this Issue feels very good. Thanks!

🌻 /Olle

[d-m-u]

I've got the Lint/Loop one.

[iMacTia]

@d-m-u @onk thanks for your patience, I've resolved a bunch of offences automatically and updated the list above 👍
If you want to help, please follow the below:

1. Leave a comment here before starting, stating the rule(s) you're taking care of
2. Branch from master into a new branch
3. Remove the rule(s) you want to fix from the .rubocop_todo.yml file
4. Run rubocop to see the offenses
5. Fix the offences
6. Commit, push and open a PR

Thanks ❤️ !

[d-m-u]

I've also got the Style/GuardClause and the Naming/VariableNumber and the Style/CaseEquality thing and the Naming/ConstantName one, and the Style/NumericPredicate and the Lint/AssignmentInCondition and the MultilineTernaryOperator one. I swear that's it though.

edit fine also the Naming/PredicateName and the Style/IfUnlessModifier and the Layout/LineLength but I expect that one will be needing a few reviews 😆