GithubHelp home page GithubHelp logo

Comments (13)

bhavik001 avatar bhavik001 commented on June 5, 2024

Hello!
I was implementing the ESLint Feature and I have just try to implement with on folder that is test and I am getting the below errors. Where did Tools came from. There is one solution for the Tools I can make it as a global variable in the eslintrc.js file. Then it will be okay. The second error is done. This is declare but the value never used. So, the solution is to remove.

There are so many error like this. If you give me permission to edit files than I can do it.
Please reply.

image

from whitebophir.

lovasoa avatar lovasoa commented on June 5, 2024

Yes you'll need to edit the files.

Tools is defined here: https://github.com/lovasoa/whitebophir/blob/master/client-data/js/board.js#L27

from whitebophir.

bhavik001 avatar bhavik001 commented on June 5, 2024

Hey,
I have created a pull request please look into it and also I am creating a document which consist of the line number and error that I have disable. Also don't close this pull request after merging it.

from whitebophir.

lovasoa avatar lovasoa commented on June 5, 2024

you closed the pr

from whitebophir.

bhavik001 avatar bhavik001 commented on June 5, 2024

Remaining ESLint Error.txt
Hey
I have created new pull request and the above file consist of the changes we have to do. For now I have disable ESLint for that particular line.

Also it is ready to merge

from whitebophir.

lovasoa avatar lovasoa commented on June 5, 2024

Hello! I don't think we can consider this ready to merge until you fix the actual eslint errors. You can't just disable lints everywhere and call it a day.

from whitebophir.

bhavik001 avatar bhavik001 commented on June 5, 2024

Yup, I am continue my work. Just need some help to understand some part of the code.

from whitebophir.

lovasoa avatar lovasoa commented on June 5, 2024

Sure, let me know what you need help with

from whitebophir.

bhavik001 avatar bhavik001 commented on June 5, 2024

Hey,
I have updated the file and also dealt with all the errors. Please review the code and also the code is ready to merge.

from whitebophir.

bhavik001 avatar bhavik001 commented on June 5, 2024

Hey,
I have updated the file and remove everything as mention by you. Please review once and let me know if I have to make changes.

from whitebophir.

bhavik001 avatar bhavik001 commented on June 5, 2024

Hey
Please let me know if the changes I have made is good to go or I should revert it. I have replied you with the explanation on the changes.

from whitebophir.

bhavik001 avatar bhavik001 commented on June 5, 2024

Hey
Please review the last commit that I have pushed and let me know if that is good or need more modification. Also let me know if it is good for merge.

from whitebophir.

lovasoa avatar lovasoa commented on June 5, 2024

I receive the notifications from the pull request already. No need to keep posting in this issue every time you update the PR :)

from whitebophir.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.