Frustum culling seems to have some problems about emerald-engine

[Isakwiberg]

Even worse when models scale is big. Spawn a cube with scale around 10 and it wont be visible at all for example.

[hansfilipelo]

Lage and I fixed this (I think) for other models. Does this only affect flat-shaded models?

/H-F

30 apr. 2016 kl. 11:59 skrev Isakwiberg [email protected]:

Even worse when models scale is big. Spawn a cube with scale around 10 and it wont be visible at all for example.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub #30 (comment)

[Isakwiberg]

Tried just now on scale_model branch and a nanosuit with scale 10 gets culled away from many camera positions. Setting the glClearColor to something other than black lets you try with cubes that are not flat shaded. And they also disappear from many camera positions and angles when they should be visible.

[hansfilipelo]

Think this line in Model.cpp could be a problem:

glm::vec3 r_vector = 0.5f * (max_corner - min_corner);

The radius isn't half the difference of the max_corner and min_corner - it should be just:

glm::vec3 r_vector = 0.5f * max(max_corner, min_corner);

Since the radius is calculated from 0 in model coordinates.

[hansfilipelo]

Nope that totally fucked shit up...

[Isakwiberg]

Fixed a few days ago. Thank you Erik!