make graphAPI endpoints customizable about lsc-microsoft-graph-api-plugin

[davidcoutadeur]

The new parameters: authenticationURL, usersURL and scope were mandatory.
I have made them optional.

With this last fix, I think the feature is ready. I am making the MR

[davidcoutadeur]

@remk @rouazana could you review my patch for the configuration parameters?
(for info, I haven't tested yet, it just passes the compilation)

[remk]

👍 it looks good to me

[davidcoutadeur]

With the last patch, the code is functional on a customized tenant.

[rouazana]

With the last patch, the code is functional on a customized tenant.

can you explain this fix? Anyway it could probably be rewritten without regxep

[davidcoutadeur]

the default hard-coded scope during authentication was https://graph.microsoft.com/.default

However, this URL depends of the usersURL parameter. I made it built on the top of the users URL.

I didn't find documentation explaining if there could be other type of scopes. If so, maybe we would have to make it a completely distinct parameter.

PS: The regex is here for making sure there is no surnumerous / at the end of the users URL

[rouazana]

thank you, I then prefer than we have a completely different scope parameter, it will make the intent clearer (and avoid this regexp ^^)

[davidcoutadeur]

regexes are beautiful :)

Last patch create a new parameter for the scope. I have tested right now, it's working on my use case. (with customized endpoints and standard endpoints)

[rouazana]

thank you, that's far better. We could avoid variable re-allocation, but it's not a big issue for me in this case.

Can you open a pull request so that we can merge it?

[rouazana]

fixed in v1.1