Comments (10)
The new parameters: authenticationURL
, usersURL
and scope
were mandatory.
I have made them optional.
With this last fix, I think the feature is ready. I am making the MR
from lsc-microsoft-graph-api-plugin.
@remk @rouazana could you review my patch for the configuration parameters?
(for info, I haven't tested yet, it just passes the compilation)
from lsc-microsoft-graph-api-plugin.
from lsc-microsoft-graph-api-plugin.
With the last patch, the code is functional on a customized tenant.
from lsc-microsoft-graph-api-plugin.
With the last patch, the code is functional on a customized tenant.
can you explain this fix? Anyway it could probably be rewritten without regxep
from lsc-microsoft-graph-api-plugin.
the default hard-coded scope during authentication was https://graph.microsoft.com/.default
However, this URL depends of the usersURL parameter. I made it built on the top of the users URL.
I didn't find documentation explaining if there could be other type of scopes. If so, maybe we would have to make it a completely distinct parameter.
PS: The regex is here for making sure there is no surnumerous / at the end of the users URL
from lsc-microsoft-graph-api-plugin.
thank you, I then prefer than we have a completely different scope parameter, it will make the intent clearer (and avoid this regexp ^^)
from lsc-microsoft-graph-api-plugin.
regexes are beautiful :)
Last patch create a new parameter for the scope. I have tested right now, it's working on my use case. (with customized endpoints and standard endpoints)
from lsc-microsoft-graph-api-plugin.
thank you, that's far better. We could avoid variable re-allocation, but it's not a big issue for me in this case.
Can you open a pull request so that we can merge it?
from lsc-microsoft-graph-api-plugin.
fixed in v1.1
from lsc-microsoft-graph-api-plugin.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lsc-microsoft-graph-api-plugin.