GithubHelp home page GithubHelp logo

Comments (3)

seydar avatar seydar commented on July 26, 2024

I think this is a fix:

`
module YARD
module Generators::Helpers
module HtmlHelper
def tag_attrs(opts = {})
opts.map {|k,v| "#{k}=#{url.escape(v.to_s).inspect}" if v }.join(" ")
end

  private
  # http://railsruby.blogspot.com/2006/07/url-escape-and-url-unescape.html
  def url_escape(string)
    string.gsub(/([^ a-zA-Z0-9_.-]+)/n) do
      '%' + $1.unpack('H2' * $1.size).join('%').upcase
    end.tr(' ', '+')
  end
end

end
end
`

I have yet to test this (I'm at school right now), but post back whether it works or not. I'll try this out myself when I get home.

from yard.

nex3 avatar nex3 commented on July 26, 2024

This doesn't seem to work. Also, HtmlHelper already has a urlescape method.

from yard.

lsegal avatar lsegal commented on July 26, 2024

Properly encode URLs for methods with punctuation. Based on nex3's patch but modified slightly and specs added.

Closed by 6f6db62

from yard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.