Comments (3)
Having the CSS extracted allows you to simplify your props, meaning that they will handle stuff related to the component itself and not styling, it's more like a separation of responsibility. In cases where it's a simple component, having props to set classes and stuff such as colors are just fine but in your case where it's kinda complex, it can't be all tied up to one style.
+1 for extracting the CSS file and allow people to import it separated and create themes.
from vue-cool-lightbox.
Great! Thanks for your explanation!
from vue-cool-lightbox.
Looking at the issue #15, what do you think is the best or proper way to handle this? Using props or extract the CSS file and allow developers to change those colors via CSS?
from vue-cool-lightbox.
Related Issues (20)
- Clicking background doesn't close light box from version 2.7.3 HOT 1
- Ability to control zoom slider with the mousewheel HOT 1
- Add functionality to view Zip archives HOT 1
- Translations
- Videos with uppercase extension not recognized
- Manual call and links
- overlayColor prop does not worjk properly HOT 1
- Will you bring vue 3 update in your package? HOT 5
- Fullscreen on close is not disabled
- How to show all the thumbnails always? HOT 2
- Prop for enabeling the thumbnails display per default?
- Documentation not available
- Component name casing (`CoolLightbox` instead of `CoolLightBox `)
- Support for multiple image formats (webp, avif)
- Image path url
- Single video on click
- Integration with nuxtjs3 HOT 3
- In horizontal mode all images too small
- Tabbing Accessibility
- Not cool HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vue-cool-lightbox.