GithubHelp home page GithubHelp logo

Comments (8)

migo315 avatar migo315 commented on September 28, 2024 1

I have clients where they store the video url like this https://www.youtube.com/watch?v=YOUTUBE_ID and in that way doesn't work.

Ah yes. That make sense. Well, then I think the prop is enough. It doesn't have to be more complicated than necessary.

from vue-cool-lightbox.

lucaspulliese avatar lucaspulliese commented on September 28, 2024 1

Hi @migo315.

Now in version 2.3.0 you can use a prop called youtubeCookies, by default is true, if you set the prop to false it will work with https://www.youtube-nocookie.com/embed/YOUTUBE_ID

from vue-cool-lightbox.

migo315 avatar migo315 commented on September 28, 2024 1

Cool! I will test it tonight. ;-)

from vue-cool-lightbox.

migo315 avatar migo315 commented on September 28, 2024 1

Works perfectly! Click here if you want to see it action.

Thanks for that ;-)

from vue-cool-lightbox.

lucaspulliese avatar lucaspulliese commented on September 28, 2024

Hi @migo315!

First of all, thanks for the star.

Sure, I will add it, I didn't know that exists.

But I have a question. What do you thinks is better, just add to all youtube videos the embed video with less cookies or add a prop to decide between the one that add more cookies or the one that add less?

Currently what the lightbox do is get the youtube ID from the inserted url and use it in https://www.youtube.com/embed/YOUTUBE_ID

from vue-cool-lightbox.

migo315 avatar migo315 commented on September 28, 2024

First of all, thanks for the star.

It's a cool Lightbox library. ;-)

Currently what the lightbox do is get the youtube ID from the inserted url and use it in

Ok, but why don't you use the url directly? Generally, I would prefer if the library use the URL which I pass to items. But if that not possible, then a prop would be cool. The developer should decide which Embed variant should be use in his project.

from vue-cool-lightbox.

lucaspulliese avatar lucaspulliese commented on September 28, 2024

Ok, but why don't you use the url directly?

I don't use the url directly because is an iframe and only works with embed youtube videos.
I have clients where they store the video url like this https://www.youtube.com/watch?v=YOUTUBE_ID and in that way doesn't work.

But now thinking on it I could solve it checking if the URL is a youtube video and has 'embed' I will use it directly, if not there you decide wich embed variant should be use with a prop.

What do you think?

from vue-cool-lightbox.

lucaspulliese avatar lucaspulliese commented on September 28, 2024

You are welcome!

And thanks, I always want to see sites that are using this component, it makes me feel good haha.
By the way, good site, I like the design :)

from vue-cool-lightbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.