GithubHelp home page GithubHelp logo

Comments (8)

lucaspulliese avatar lucaspulliese commented on August 18, 2024 1

Hello! Thanks!

Oh I see, I think I should add something like bodyScrollLock, wich I thinks is more tested than the solution than I did.

Thanks @kimanihuon, I will let you know when is fixed.

from vue-cool-lightbox.

lucaspulliese avatar lucaspulliese commented on August 18, 2024 1

Hi again @kimanihuon! I added bodyScrollLock in version 2.6.0, tell me if everything works fine for you.

from vue-cool-lightbox.

hkimani avatar hkimani commented on August 18, 2024 1

Hi, awesome. The scrolling issue has been fixed. Thank you very much.

from vue-cool-lightbox.

lucaspulliese avatar lucaspulliese commented on August 18, 2024 1

Let me check it out and I'll tell you what it might be

from vue-cool-lightbox.

schellmax avatar schellmax commented on August 18, 2024 1

might be related, using the CDN version i get the following error in the console:

vue-cool-lightbox:1 Uncaught ReferenceError: bodyScrollLock is not defined

so had to add
<script src="https://cdn.jsdelivr.net/npm/[email protected]/lib/bodyScrollLock.min.js"></script>
before loading vue-cool-lightbox

in the docs it said 'Pretty Vue.js lightbox without any dependencies' ;)

from vue-cool-lightbox.

lucaspulliese avatar lucaspulliese commented on August 18, 2024 1

Done @schellmax. Thanks again.

from vue-cool-lightbox.

hkimani avatar hkimani commented on August 18, 2024

One last thing, with the new update, the image doesn't update when I change the src programmatically. e.g

activeImages[0].src = newUrl

I'm thinking maybe it's a caching thing ... kindly advise.

from vue-cool-lightbox.

lucaspulliese avatar lucaspulliese commented on August 18, 2024

@schellmax Hi!

Yep, you are right, I forgot to remove that text and add that dependency to the docs for the CDN case, thanks!

from vue-cool-lightbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.