Comments (10)
I wonder the type of currConver.editor
, it's string or not?
since:
let oldHtml = oldValue && oldValue.__html
let html = value && value.__html
if (!isStr(html)) {
elem.innerHTML = ''
} else if (html !== oldHtml) {
elem.innerHTML = html
}
from react-lite.
if currConver.editor
is equal to undefined, innerHTML will also be clears.
Had better got a demo for debugging:)
from react-lite.
Yes, you're right. It is undefined
😢
But this is different with React. Is it better to make them consistent? ;)
from react-lite.
@fritx That's ok, I will check the behavior about inneHTML in this case with react, and make them consistent.
from react-lite.
Thanks! At this time, I prefer consistancy. Thank you!
But maybe in the future, react-lite's simplicity and lightweight wins!
from react-lite.
I think the version v0.0.13 of react-lite made consistancy with below change:
let oldHtml = oldValue && oldValue.__html
let html = value && value.__html
if (html != null && html !== oldHtml) {
elem.innerHTML = html
}
It won't be patched if html is equal to null or undefined such like regular react does.
try the lastest version to confirm this problem was resolved:)
BTW, I think regular react will provide lightweight version in the feature, or something like rollup \ tree shaking, make react-lite not necessary
haha ~ just wait and see what will happen.
from react-lite.
@Lucifier129 haha~ ok, wait a sec
from react-lite.
Ok alright!
- It won't be patched if html is equal to null or undefined
- It will be patched if html is equal to empty string
from react-lite.
That's good:)
from react-lite.
issue should be closed 👍
from react-lite.
Related Issues (20)
- Possible reasons react-lite results in ~2KB bundle size reduction? HOT 1
- Module not found: Error: Can't resolve 'react-dom/lib/HTMLDOMPropertyConfig' HOT 1
- Uncaught Error: must set key for <rc-animate> children
- history.push() inside componentWillReceiveProps breaks destroyVcomponent() HOT 3
- Cannot set property 'parentContext' of undefined HOT 9
- Strips out iOS `playsInline` attribute
- Audio event support
- Draft.js
- Cannot set property 'parentContext' of undefined HOT 2
- not an issue! I need a developper , website using react-lite with material-ui HOT 1
- react-lite doesn't throw errors if ReactLite is loaded twice on page HOT 2
- Recommendation: component RUM performance react-lite vs react HOT 1
- 菜单高亮只会初始化一次,之后的点击不会生效
- material-ui tabs won't work
- Not triggering click event the first time when used with material-ui HOT 2
- Select Value not selecting option HOT 7
- plans for react 16 compatible? HOT 3
- onClick handler triggered for disabled button
- Should I install fastclick by myself? HOT 3
- Uncaught InvalidStateError: Failed to execute 'setSelectionRange' on 'HTMLInputElement': The input element's type ('number') does not support selection. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-lite.