GithubHelp home page GithubHelp logo

Comments (7)

Lucifier129 avatar Lucifier129 commented on July 24, 2024

React-lite always use createElement, never use innerHTML to create real dom, but use to clear current childNodes of container dom.

from react-lite.

himalayafan avatar himalayafan commented on July 24, 2024

Why not use reacts way to cleanup the children of container dom? Just a simple while loop. Faster too

from react-lite.

Lucifier129 avatar Lucifier129 commented on July 24, 2024

The first, you are wrong about the way react-lite handle vdom to real-dom

The second, you should show me the perf-test to prove what you said, and had better fork react-lite and pull request to me.

Talk is cheap!

from react-lite.

himalayafan avatar himalayafan commented on July 24, 2024

https://jsperf.com/innerhtml-vs-removechild/394

from react-lite.

Lucifier129 avatar Lucifier129 commented on July 24, 2024

That is good, hope next time you open issue will show the evidences directly ; )

Will resolve it soon.

from react-lite.

himalayafan avatar himalayafan commented on July 24, 2024

And next time I hope authors of repos I visit at least have basic knowledge about things

from react-lite.

Lucifier129 avatar Lucifier129 commented on July 24, 2024

Come on, if innerHTML vs removeChild is basic knowledge everyone knows, and why someboy create https://jsperf.com/innerhtml-vs-removechild/394 ?

Additionally, use innerHTML to clear container is not commonly usedery in react-lite, The improve of changing innerHTML to removeChild is very limited .

This issue even not worth mentioning.

from react-lite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.