an extension point similar to json-unit.regex about jsonunit

[lukas-krecan]

Hi, thanks for feedback. To be honest, capturing values does not seem to fit to the library. There are several possible solutions.

1. Use json-path to access the values
2. Use Hamcrest matchers. You can already use Hamcrest matchers with JsonUnit like this assertThatJson("{\"test\":\"one\"}").node("test").matches(equalTo("one")); You can use custom capturing matcher (similar to Mockito ArgumentCaptor)

[k1w1m8]

Hi, I agree that it doesn't. 😀 It's more the generalisation of the underlying mechanism of json-unit.regex that I am after. I have other use cases which require that generalisation as well. It basically allows a general extension mechanism customise comparison for any node. Using matchers is not applicable for me because I am doing integration testing where the Java API is not accessible - the tests are written by non developers. My driver here is that I'm trying to do similar things with json that I already do for XML using xml-unit. It has a call back API which let me implement my own version of json-unit.regex for XML. Would you consider a pull request demonstrating what I am thinking of?

…

On Fri, Jun 23, 2017, 3:48 AM Lukáš Křečan ***@***.***> wrote: Hi, thanks for feedback. To be honest, capturing values does not seem to fit to the library. There are several possible solutions. 1. Use json-path to access the values 2. Use Hamcrest matchers. You can already use Hamcrest matchers with JsonUnit like this assertThatJson("{\"test\":\"one\"}").node("test").matches(equalTo("one")); You can use custom capturing matcher (similar to Mockito ArgumentCaptor) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#67 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKp_ENdzFvaQmWHeTKNxDeByrVFj8g4Sks5sGqjfgaJpZM4OAU8f> .

[lukas-krecan-lt]

Sure, PRs are always nice.

It reminds me this feature recently added to JsonUnit a2c26ab#diff-6c9cdaf0685d47feb195c5cd7da1eb5aR1021 isn't it what you need?

[k1w1m8]

Unfortunately not. I should have anticipated it - fair point. Hamcrest matchers are good for unit testing but won't accommodate json-unit.regex style comparison.

…

On Fri, Jun 23, 2017, 6:04 PM lukas-krecan-lt ***@***.***> wrote: Sure, PRs are always nice. It reminds me this feature recently added to JsonUnit a2c26ab #diff-6c9cdaf0685d47feb195c5cd7da1eb5aR1021 <a2c26ab#diff-6c9cdaf0685d47feb195c5cd7da1eb5aR1021> isn't it what you need? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#67 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKp_EB5lyE6Ki7b5h7pTVpM6XvZrJp8Aks5sG3FcgaJpZM4OAU8f> .

[lukas-krecan-lt]

OK, I see what you mean. You need additional param. Something like

assertJsonEquals("{\"test\": \"${json-unit.matches:mymagic}[param]\"}", "{\"test\":1}", JsonAssert.withMatcher("mymagic", myMagicInstance)); That can be done.

[lukas-krecan-lt]

No need for PR, I think I know what to do. If you do not mind, I will base it on matchers, will just add a parameter.

[lukas-krecan]

What about this? c85a70f#diff-6c9cdaf0685d47feb195c5cd7da1eb5aR1030

[k1w1m8]

Looks good to me. Extending Matcher fits in elegantly after all 😀. Thanks!

…

On Sat, Jun 24, 2017, 6:17 AM Lukáš Křečan ***@***.***> wrote: What about this? c85a70f#diff-6c9cdaf0685d47feb195c5cd7da1eb5aR1030 <c85a70f#diff-6c9cdaf0685d47feb195c5cd7da1eb5aR1030> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#67 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKp_EAv1b7NY8TCJASclq9udXf8wyhPZks5sHB1ggaJpZM4OAU8f> .

[lukas-krecan]

Released as 1.24.0

[k1w1m8]

Awesome. Thanks.

…

On Sat, Jun 24, 2017, 4:17 PM Lukáš Křečan ***@***.***> wrote: Released as 1.24.0 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#67 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKp_EBFCED9ER2nK6_BhrcwuBxBO6jmnks5sHKn9gaJpZM4OAU8f> .

[k1w1m8]

Finally got around to actually using this for real, worked perfectly. I can now compare both XML documents using XML unit, and JSON documents using JsonUnit and, as a side effect of the comparison, capture values into user defined variables using a similar ${} extension mechanism. Brilliant.