Comments (3)
Hey @combdn, thanks for the report! The reason, why the blur-based rename aborting didn't work with the blueprintjs renderers, was because the rename-submit button required registration through a ref, so essentially this was the fix. If this ref is missing, the library can't figure out if the input-blur happened because the user clicked on the submit button, in which case we of course don't want to abort renaming.
The current default is of course not a great one, so as of 2.4.3 I've changed it to still properly abort renaming if the submit button ref was not passed (e.g. if no submit button exists). But if you do have a rename-submit button, you probably also want to add the ref to the button.
from react-complex-tree.
Thank you very much for fixing it!
BTW, Iām finding Blueprint JS renderers a great reference. I think they deserve more emphasis in the docs as such.
from react-complex-tree.
Happy to hear! Good point, yeah they would probably make sense to mention in relation to how to write renderers, I'll expand that docs section.
from react-complex-tree.
Related Issues (20)
- Expose treeItem internals HOT 1
- Item sort order is not maintained when reparenting multiselections HOT 1
- can make overrideOldSelection is customizable when calling selectUpTo? HOT 1
- Data fetching & virtualization HOT 3
- Can't focus tree by using just keyboard. HOT 4
- Enable setting custom `TreeItemElement` component HOT 1
- Indirectly selecting the starting item in a `shift` multiselect action results in an incorrect multiselection HOT 3
- custom styling causing drag between line in incorrect position HOT 4
- How to update the browser history / url in the address bar when triggering onPrimaryAction={onSelect} in order to be able to reload the page selecting the same tree item? HOT 3
- OnDrop returns not correct childIndex for target.targetType = 'between-items' HOT 3
- Drag and Drop does not work when title is Anchor <a> tag HOT 5
- Context Menu For Each Folder And Item HOT 3
- Multiple drag an drop items get inserted in wrong order HOT 1
- UncontrolledTreeEnvironment is throwing error HOT 2
- a.createContext is not a function HOT 4
- no nodes in the tabOrder after drop on non-expanded parent HOT 1
- Illegal drag-between and drag-over is allowed with key commands HOT 12
- Arrow Direction Not Changing Based on Language/Orientation (RTL/LTR) HOT 2
- [Question] How does it work with reactflow? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-complex-tree.