Comments (8)
Hi @dgreene1, thanks for your report! Can you give some specific examples which keys you pressed and in which example (which storybook story or deployed example). For me the keybindings work as expected.
from react-complex-tree.
Ah I found an issue from the last time I worked on some performance upgrades, I'm looking into it. Pretty sure that those issues where introduced after the last release though, this should not happen on any consumable version of the library at the moment.
from react-complex-tree.
@lukasbach I was able to replicate it in the “playground” link on the website so it is occurring out in the published version.
from react-complex-tree.
Can you kindly try if you can still replicate it? I did some fixes, and it should hopefully not happen anymore.
Btw. the playground shows the current state on master, but the last release to npm was some time ago before I did the changes that probably caused the issue, so consumers of the library should not be affected, that's what I meant with published version, sorry for the misunderstanding.
from react-complex-tree.
Yes, it's still a problem. I'll give the reproduction steps I just used:
- turn on NVDA
- open up Firefox
- visit #56
- press tab (which should show that the tree is focused
- press enter
expected results:
the first folder should collapse (since it was already open)
actual results:
focus leaves the tree and goes somewhere else. I think it goes to rct-livedescription-tree-1
Comments:
Can this rct-livedescription-tree-1 div be removed and made a part of the documentation instead of part of the actual widget?
from react-complex-tree.
focus leaves the tree and goes somewhere else. I think it goes to rct-livedescription-tree-1
I noticed this too. The default live description contains a link which takes focus even though it is not visible on the screen.
Can this rct-livedescription-tree-1 div be removed and made a part of the documentation instead of part of the actual widget?
This can be done in your own app with the renderLiveDescriptorContainer
prop. But the link should probably be removed or made non-focusable in the default implementation.
from react-complex-tree.
The link in the live descriptor region should not be there anymore, I removed that in 8a45c1f and deployed afterwards...
Also note that enter does not toggle the collapsed state of an item, it only selects and invokes the primary action, but space does.
from react-complex-tree.
I'll close this for now, please let me know if any other issues persist.
from react-complex-tree.
Related Issues (20)
- DROP not working when open a new folder. HOT 3
- Customize Cursor when Dragging HOT 1
- Example for drag and drog with controlled tree? HOT 1
- Request for `context.stopRenamingItem(item.index)` as counter for existing startRenamingItem function HOT 2
- Cannot read properties of undefined (reading 'index') HOT 3
- tree update HOT 1
- Drag custom files to the tree HOT 2
- Text selection on title don't work HOT 3
- Missing `activeTreeId` in `TreeEnvironmentRef<T,C>` type HOT 1
- Set state on unmounted component HOT 8
- Tree is missing `multiselect` prop HOT 2
- I want to print node contents. HOT 1
- Unable to update tree data using custom Data Provider HOT 3
- Collision with react-dnd HOT 2
- Search whole tree HOT 5
- Animation when node is opened and closed HOT 3
- `renderItem` and `renderItemTitle` rerenders causes performance hits HOT 1
- customize keyboard bindings HOT 1
- Custom search HOT 1
- Expand tree element without selecting it HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-complex-tree.