Comments (8)
I suppose that instead of me @CJ42 expected to be tagged :)
from lips.
Lets go with Call renounceOwnership()
2x within 100 blocks
from lips.
from lips.
event RenounceOwnershipInitiated(...)
There should be as well a deadline for renouncing ownership.
// renounceOwnership(...). // ---------------------> timeline to confirm <---------------//
block n -----------------> block n + 50 ---------------------------------------------> block n + 150 ------------------> timeout
After block n + 150
, this is a timeout and the process has to start all over again.
from lips.
@frozeman adding this as a comment for clarity (as it is mentioned in the first comment of the issue.
We agreed on calling the same function renounceOwnership(...)
twice ✅
(no functions or confirmRenounceOwnership()
) ❌renounceOwnershipConfirm()
from lips.
It was decided to make renounceOwnership(..)
a two step process action, where the the user calls renounceOwnership(..)
, which starts a time in blocks, where for the first 100 blocks, he can not complete the renouncement, and after 100 blocks he has the ability to call renounceOwnership(..)
again to complete the renouncement. If after 200 blocks after the initial call to renounceOwnership() the process was not completed, the user will have to start all over again. We also added a RenounceOwnershipInitiated Event to notify the user that renounceOwnership(..)
was called for the first time.
This will allow for a delay time for the owner to act, if a malicious controller initiated the process. And allows for an expiry, the process is not completed within 100 blocks (~20min)
from lips.
@frozeman Can we use block.timestamp
instead of block.number
?
from lips.
Closing as implemented in #129 ✅
from lips.
Related Issues (20)
- [UP Extension] Add Compatibility for multiple Web3-Extensions HOT 4
- [LSP6] Add EIP-1271 verification mechanism for relay calls
- Add gas limit to calls of a controller with only SUPER_TRANSFERVALUE permission HOT 1
- Differentiating between a Deleted Data Key and an Unset Data Key HOT 1
- [LSP2] CompactBytesArray - complete technical overview with examples HOT 6
- [LSP2] Tuple encoding HOT 1
- [LSP0] Improve LSP0 Anti-Phishing by Adding Transfer Delay HOT 3
- [LSP24] Multichain Address Resolution HOT 5
- [LSP11] SocialRecovery Improvement HOT 8
- [LSP25] Execute Relay Call as its own standard (extracted from LSP6)
- [LSP4] Add Background image field to LSP4 JSON Metadata HOT 4
- [LSP7,LSP8] Non-transferable flag HOT 1
- [LSP1] Gas Limit for Universal Receivers HOT 2
- Remove `JSONURL` and only use `AssetURL`?
- Add Currency Symbol (Ŀ) For Lukso
- [LSP2] Add `contract` / `Contract` as a valid valueType + valueContent
- [LSP8] Discussion - truncation of `bytes32` tokenId for keyTypes Mapping
- ..
- [LSP8] Define if `0x` prefix should be added to `LSP8MetadataBaseURI` HOT 1
- Icon Request: icon-lyx HOT 18
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lips.