Missing minimum CMake version in Hologram demo about vulkansamples

[TonyBarbour]

Running CMake at the root of repo to create all the makefiles and then going to the Hologram directory and running make builds just Hologram - is that sufficient? I don't think we need to support running CMake in subdirectories

[olvaffe]

Hologram relies on the top-level CMakeLists.txt to perform the check. Is it advised each subdirectory perform the check itself?

Or were you trying to run cmake from within Hologram? That would make sense, but Linux build would still fail because FindXCB.cmake would be missing.

[SaschaWillems]

Or were you trying to run cmake from within Hologram? That would make sense, but Linux build would still fail because FindXCB.cmake would be missing.

Exactly. I only wanted to compile the Hologram demo without having to build all dependencies for the other examples, so I used it's CMakeLists.txt. On windows this works fine.

[olvaffe]

There are common setups (FindXCB.cmake included) that cannot be found in Hologram's CMakeLists.txt. I guess the right way here is for the top-level CMakeLists.txt to make samples and their dependencies optional.

[ChristophHaag]

FindXCB.cmake is in extra-cmake-modules

According to http://api.kde.org/ecm/manual/ecm-find-modules.7.html adding

find_package(ECM REQUIRED NO_MODULE)
set(CMAKE_MODULE_PATH ${ECM_FIND_MODULE_DIR})

in front of find_package(XCB REQUIRED) lets cmake find it.

I also had to add set_property(TARGET Hologram PROPERTY CXX_STANDARD 11) because this cmakelists file doesn't set c++11.

Oh and from the Hologram directory, you also need to put a glslang build e.g. ln -s /wherever/glslang ../../../glslang.

With all that I could build it "standalone".
Tl;dr: ChristophHaag@c491ec9

Does LunarG want to support "standalone" builds of the samples like that?

[TonyBarbour]

Also, after running CMake from the root of the repo, running "make Hologram" will also just make the Hologram sample

[TonyBarbour]

Closing - please open a new issue if there is still a problem