GithubHelp home page GithubHelp logo

Comments (5)

hishamhm avatar hishamhm commented on September 27, 2024

No reason other than nobody did it yet. :)

A proper implementation needs the following:

  • version checks to make sure that the APIs are available (that is, that all Windows versions that luafilesystem currently supports will continue to build without breaking)
  • implementations that make sense with the lfs APIs (for the lfs.link function for example, if Windows supports symbolic links only and not hard links, the function should only create a link when the third argument is true)
  • check that the existing tests run and exercise the new code (and add some if necessary)
  • following the coding style of the rest of the code (variable names, indentation, etc.)

from luafilesystem.

moteus avatar moteus commented on September 27, 2024

Just note. Windows support hard link since win2k3

from luafilesystem.

brisingraerowing avatar brisingraerowing commented on September 27, 2024

As a side note, there is a library called LibNTLink that implements link(), symlink(), unlink(), lstat(), and readlink() on Windows. Maybe that library would be of use.

I am currently in the process of editing LFS to make it use LibNTLink for this.

from luafilesystem.

hishamhm avatar hishamhm commented on September 27, 2024

@brisingraerowing that's interesting, but according to the link it requires GCC and win32api MinGW packages. LFS also runs with MSVC.

from luafilesystem.

brisingraerowing avatar brisingraerowing commented on September 27, 2024

I'll take a look and see if I can get it to compile with MSVC. Looking at the code it doesn't use any GCC-Specific things, so it shouldn't take too much to get it working.

It does have a few compilation bugs though (missing method parameters mostly), but those are easily fixed.

from luafilesystem.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.