GithubHelp home page GithubHelp logo

Comments (6)

filiptibell avatar filiptibell commented on September 3, 2024 1

Going to close this issue since it was resolved and is neither a bug nor feature request related to Lune, as mentioned above feel free to create an issue in rbx-dom and discuss over there

from lune.

benbrimeyer avatar benbrimeyer commented on September 3, 2024

Apologies, I had to zip the file to upload it to github.
I've updated the report to clarify

from lune.

kennethloeffler avatar kennethloeffler commented on September 3, 2024

I can't reproduce "Failed to read document from buffer - stream did not contain valid UTF-8". I see no problems from either lune or rbx-dom (lune's roblox library) after unzipping this file. If I leave your file zipped and then run the lune script, I see Unknown document format, which I expect. I'm not sure how you're getting that first error message.

Can you provide more details on how you're getting this to occur?

from lune.

benbrimeyer avatar benbrimeyer commented on September 3, 2024

Sorry I may have uploaded the wrong file. I've updated the OP with two files for the two different errors

from lune.

benbrimeyer avatar benbrimeyer commented on September 3, 2024

Ran with lune v0.6.6 with RUST_LOG level to trace and got this:
$ RUST_LOG=trace lune test.log

Issue was weird unicode in a RotateP (virus) instance.

from lune.

kennethloeffler avatar kennethloeffler commented on September 3, 2024

Can't see any problem with unknown_document_format in your updated files - it looks to read just fine to me!

I can reproduce the problem with did_not_contain_valid_utf8, and it makes sense. The core of this problem is that Roblox is lax about the data it allows in strings, while rbx-dom and Rust programs in general strictly enforce that strings are always UTF-8 encoded.

I think it's probably pretty uncommon for place/model files in the wild to contain non UTF-8 strings, but if it's really important for your use case that these kinds of files aren't rejected then rbx-dom must do something else about funny-lookin strings. I think it'd be good to come up with some more information about your use case (for example: is it important that the data is preserved 1-1, or would a lossy conversion be ok?) and then open an issue over at rbx-dom

from lune.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.