List of available software items does not word-wrap about luci-theme-material

[LuttyYang]

@hnyman maybe i fix it in version 0.2.6

[hnyman]

Sorry, but after compiling and flashing the version at Openwrt Luci after your pull request (matches 0.26, I think) I still see no word-wrapping there.

[LuttyYang]

Could you tell me that you are using environmental information it?

E.g:
System: Ubuntu 15.04
Browser: Firefox dev 38.0.1

[hnyman]

I mainly use Firefox 43 x64 in Window 7 x64
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0
ID:20151005004046 CSet: 58f5e8ddaa59b31dec9938a83cc24210cb514896

also IE11, standard version.
Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; rv:11.0) like Gecko

And the word-wrap does not work in either. Instead, the description field is one long line.

Firefox 43:

IE11:

[LuttyYang]

@hnyman I test IE11, but it look like good...

[hnyman]

Hmmm. interesting.
I am testing with the version uplifted to Openwrt repository with the pull request yesterday, not the local 0.26. Is there a difference?

(EDiT: I downloaded and installed 0.26, but no wrap)

I thought about cache problems and also tested in Virtualbox Ubuntu with a virgin Firefox 41, and no wrap.

[LuttyYang]

@hnyman I compared the https://github.com/LuttyYang/luci-theme-material/blob/master/files/htdocs/css/style.css and https://github.com/openwrt/luci/blob/master/themes/luci-theme-material/htdocs/luci-static/material/css/style.css.

They look the same file....

[LuttyYang]

I tested FireFox, it also look like good...

I think maybe the javaScript have some problems. Could you take a screenshot of this page? you need press F12 in this page, it look like this:

[hnyman]

I also tested with Chrome from my tablet and no wrap.

I just recompiled and flashed a new version to the router, but no change.

You mean this screen?

[hnyman]

Just making sure that we are talking about the same version:

which change in 0.26 was supposed to cause the wrapping?
7cce322

or has it been wrapping ok for you all the time?

[hnyman]

one more screenshot, with moer drilling down to the table item level:
If I understand the pop-up item info ok, the field is 4990 pixels wide.

[LuttyYang]

@hnyman

[LuttyYang]

I thought it maybe the LUCI Template have some changes?

[hnyman]

You are not using the newest Openwrt trunk version, as your software page has no package size information.

[LuttyYang]

@hnyman Okay... It seems that I need build a newest version for my router ...

[hnyman]

Yeah, it looks like you are not using the newest Luci code , as your software page has no package size information. opkg size that was added to Luci on September 16th by openwrt/luci@3288fe7

You need to sync your sources.

[hnyman]

Just tested: after manually changing style.css to affect 5th column instead of 4th, the description column started to wrap. So, the style in 0.26 is based on older luci code.

Looks like the styling is so detailed that it may cause additional work when there are changes in Luci. Is the a fundamental reason, why all the columns are not wrapping in this table? That might ease things in future.

Luci evolves all the time, so the more flexible the styling is, the better it works automatically.
(some historical background: the package version string shown in this table was up to ~55 characters still a few feeks ago. Then its display was shortened to max 26 chars, decreasing the need to wrap that column. But earlier that field got often wrapped, too. There are constantly minor tweaks, so the detailed formatting may prove to be burdensome at some point.)

screenshot about the working 5th column wrapping

[LuttyYang]

@hnyman I also thinking this problem, LUCI Template have many old HTML, example, all button used input(style is button) as opposed to use button. It is difficult to change one style without affecting the others.

[hnyman]

Thanks. I merged the PR and now it seems to wrap ok.