iframe src looking at root of webpage instead of iframe src directory (spa?) about local-web-server

[75lb]

which directory are you running ws from? the web_page folder?

[micsun-al]

I am running ws from the parent of "web_page".

There are multiple pages I'm testing and "web_page" is one of them.

[75lb]

if you running this command from the parent of "web_page", it will look for the file "index.html" in the same directory.. ws serves the directory it is run from ..

[Thaina]

@75lb I think the default behaviour of the common static spa server is looking for nearest parent index.html of the url first. Which means with --spa command, it should serve localhost:8000/web_page/iframe with "localhost:8000/web_page/iframe/index.html"

Actually for full step, with this author's setup. given that the request is localhost:8000/web_page/iframe

1. It should look for file web_page/iframe, if there is then serve as is
2. If missing it should check if there is any folder web_page/iframe/
   2.1. If there is, redirect to web_page/iframe/ (add the trailing / for folder)
3. If there is web_page/iframe/index.html then serve that file
4. If there is web_page/index.html then serve that file
5. If there is index.html then serve that file

Could we have this behaviour instead?

[75lb]

the syntax is ` --spa <filename>`, e.g. `--spa src/iframe/index.html`.. you specify which html file should be served as the SPA.. does that solve your issue?

…

On Thu, 10 Feb 2022, 04:26 Thaina Yu, ***@***.***> wrote: @75lb <https://github.com/75lb> I think the default behaviour of the common static spa server is looking for nearest parent index.html of the url first. Which means with --spa command, it should serve localhost:8000/web_page/iframe with "localhost:8000/web_page/iframe/index.html" Actually for full step, with this author's setup. given that the request is localhost:8000/web_page/iframe 1. It should look for file web_page/iframe, if there is then serve as is 2. If missing it should check if there is any folder web_page/iframe/ 2.1. If there is, redirect to web_page/iframe/ (add the trailing / for folder) 3. If there is web_page/iframe/index.html then serve that file 4. If there is web_page/index.html then serve that file 5. If there is index.html then serve that file Could we have this behaviour instead? — Reply to this email directly, view it on GitHub <#54 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJQV3HU7ARHYMYK5AYGJ53U2M457ANCNFSM4CUPDLWQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[Thaina]

you specify which html file should be served as the SPA.. does that solve your issue?

It's not. Because then when I go to localhost:8000 it then still try to serve src/iframe/index.html instead of src/index.html

As I said, common spa static server, firebase for example, will always recursively look for the spa file of the parents recursively. This behaviour let we host multiple app in each subdirectory

[75lb]

you can modify the spa behaviour to work in any way you like - it's just a plugin which you can fork and tweak.. see the wiki for an explanation of plugins, I'll get back to you with an example showing how to modify --spa later

…

On Thu, 10 Feb 2022, 05:27 Thaina Yu, ***@***.***> wrote: you specify which html file should be served as the SPA.. does that solve your issue? It's not. Because then when I go to localhost:8000 it then still try to serve src/iframe/index.html instead of src/index.html As I said, common spa static server, firebase for example, will always recursively look for the spa file of the parents recursively. This behaviour let we host multiple app in each subdirectory — Reply to this email directly, view it on GitHub <#54 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJQV3C5CGQK6IEWAMRZOA3U2NEFXANCNFSM4CUPDLWQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[Thaina]

Thank you for your explanation. Still I would like to beg for you to consider this behaviour as default of the plugin so that it not confused and could be loaded from npm

[75lb]

yes, that's a possibility too..

…

On Thu, 10 Feb 2022, 06:04 Thaina Yu, ***@***.***> wrote: Thank you for your explanation. Still I would like to beg for you to consider this behaviour as default of the plugin so that it not confused and could be loaded from npm — Reply to this email directly, view it on GitHub <#54 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJQV3HXM4EVHMGZ4WEBLALU2NIPBANCNFSM4CUPDLWQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>