I want a rule that will flag Exception in raises() contexts. about flake8-pytest-style

[m-burst]

Hi @jenstroeger,

I'm not sure I agree with this.
There might be code actually raising Exception (which is a bad practice by itself, but out of the scope here), so the tests will also need to catch Exception. This can also happen in third-party code, outside of the test author's control.
There already is PT011 which would force test authors to specify the match parameter for the exceptions considered too broad.

[jenstroeger]

Thank you @m-burst for your response, but I disagree.

There might be code actually raising Exception […], so the tests will also need to catch Exception.

Indeed that is correct, and in that case the flake8 warning should be suppressed with a # noqa comment — just like the pylint warning should be suppressed to clarify intent.

(which is a bad practice by itself, but out of the scope here)

I think it’s quite in scope of flake8 to encourage good coding and testing practices. Not warning at all, I think, continues to encourage bad practices.

Furthermore, by catching & testing for broad Exception a test may capture unexpected errors and therefore create a false negative. In fact, I opened this issue because I’ve seen exactly that happening a little too often and I am tired of asking people to not use Exception. Help from a tool would drive home the importance of narrowing test cases to only the necessary exceptions.

There already is PT011 which […]

That is assuming that people pass a string to an exception, which is not always the case either.