Comments (4)
for this we can pass props.location.query
to the breadcrumbs and use them in the Link
like so:
<Link to={`/location/${parent.locationKey}`} query={query}>{parent.name}</Link>
The problem is there are params that we might not want to pass up. The specific one that we have now is clientIsp
. Top client ISPs in a city will not be the top client ISPs in the country - for example.
@pbeshai - does it make sense to add something to the urlHandler
or some other portion of the URL system to extract only a subset of the params ?
urlHandler.params(exclude=['clientIsp'])
?
from mlab-vis-client.
Hmm yea that's a bit tricky. I think what we should do is create a LocationLink
component that creates the URL properly by using a subset of the props in LocationPage and the breadcrumbs can use that.
from mlab-vis-client.
As per external discussion:
Create a utility method that takes props.location.query
and the urlQueryConfig
. it will build a query object with only those query values that are supposed to be persisted.
from mlab-vis-client.
closed by #60
from mlab-vis-client.
Related Issues (20)
- Broken API link on Visualizations > Data page HOT 4
- Update menu to match new M-Lab Menu structure
- Explore options for providing users more than medians in the visualizations HOT 2
- Use Travis to deploy client
- Map "animation" is dominated by slow vectors.
- migrate from Mapzen to an alternate service for front page map
- Issue with location and data picker
- replace vis-pipeline with queries HOT 1
- Automated queries that generate BigTable Pipeline tables HOT 2
- Decide whether to continue using a BigTable Cluster JSON files in GCS HOT 2
- Add AS Name when it is available in unified views HOT 1
- Add support for aggregating by ISO 3166-2 subdivision 2 codes when they are available in unified views
- Enable date pinning via click on "/dashboard" charts
- Add type-ahead search to location drop down
- Use a color encoding on the heatmap that is easier to decipher HOT 1
- Add a toggle to change graphics from download speed to upload speed
- Review/Update to provide access to all available years & locations HOT 5
- Final content review - new dashboard page
- Inventory resources that can be retired
- Review and remove old code no longer used in the new version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mlab-vis-client.