GithubHelp home page GithubHelp logo

Comments (4)

vlandham avatar vlandham commented on August 31, 2024

for this we can pass props.location.query to the breadcrumbs and use them in the Link like so:

  <Link to={`/location/${parent.locationKey}`} query={query}>{parent.name}</Link>

The problem is there are params that we might not want to pass up. The specific one that we have now is clientIsp. Top client ISPs in a city will not be the top client ISPs in the country - for example.

@pbeshai - does it make sense to add something to the urlHandler or some other portion of the URL system to extract only a subset of the params ?

urlHandler.params(exclude=['clientIsp']) ?

from mlab-vis-client.

pbeshai avatar pbeshai commented on August 31, 2024

Hmm yea that's a bit tricky. I think what we should do is create a LocationLink component that creates the URL properly by using a subset of the props in LocationPage and the breadcrumbs can use that.

from mlab-vis-client.

vlandham avatar vlandham commented on August 31, 2024

As per external discussion:

Create a utility method that takes props.location.query and the urlQueryConfig. it will build a query object with only those query values that are supposed to be persisted.

from mlab-vis-client.

vlandham avatar vlandham commented on August 31, 2024

closed by #60

from mlab-vis-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.