GithubHelp home page GithubHelp logo

Comments (3)

M-Reimer avatar M-Reimer commented on August 31, 2024

Please always provide direct links for testing and probably a screenshot.

The Add-on should be internally blacklisted on maps.google.com.
https://github.com/M-Reimer/osm-everywhere/blob/master/handlers/google.js#L19-L27
If this does not work, then the blacklist needs fixing. The idea is that the Add-on never changes the "original website" of the map provider. It should only replace external embeds.

from osm-everywhere.

scubbx avatar scubbx commented on August 31, 2024

An example link is: https://www.google.com/search?client=firefox-b-lm&tbs=lf:1,lf_ui:4&tbm=lcl&sxsrf=ALiCzsa8yNgFD8XKH7NfdkwX2VSp4RoJ1g:1666803771743&q=aida&rflfq=1&num=10&ved=2ahUKEwjI9uX1r_76AhXDQfEDHVmwB9kQtgN6BAgtEAY#rlfi=hd:;si:;mv:[[48.233765999999996,16.4011578],[48.178816,16.2954672]];tbs:lrf:!1m4!1u3!2m2!3m1!1e1!2m1!1e3!3sIAE,lf:1,lf_ui:4

grafik

When opening maps.google.com directly, then the original map is shown. After looking at the link of my search result, I see that the domain is actually not "maps.google.com".
The link provided is the result of a "normal" www.google.com search. So adding an additional
if (origin.host.startsWith("www.google.com"))
would do the trick.

from osm-everywhere.

M-Reimer avatar M-Reimer commented on August 31, 2024

The link provided is the result of a "normal" www.google.com search. So adding an additional
if (origin.host.startsWith("www.google.com"))
would do the trick.

You are right. This should be in there, but with 'startsWith("www.google.")' to cover all the other Google domains.
But I still wonder why it covers markers. Probably my tile replacement kicks in on some requests where it shouldn't. Probably this is the right opportunity to have a deeper look into the parameter syntax used by Google. I guess the same issue could happen on other websites where similar markers are used.

from osm-everywhere.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.