Comments (3)
Please always provide direct links for testing and probably a screenshot.
The Add-on should be internally blacklisted on maps.google.com.
https://github.com/M-Reimer/osm-everywhere/blob/master/handlers/google.js#L19-L27
If this does not work, then the blacklist needs fixing. The idea is that the Add-on never changes the "original website" of the map provider. It should only replace external embeds.
from osm-everywhere.
When opening maps.google.com directly, then the original map is shown. After looking at the link of my search result, I see that the domain is actually not "maps.google.com".
The link provided is the result of a "normal" www.google.com search. So adding an additional
if (origin.host.startsWith("www.google.com"))
would do the trick.
from osm-everywhere.
The link provided is the result of a "normal" www.google.com search. So adding an additional
if (origin.host.startsWith("www.google.com"))
would do the trick.
You are right. This should be in there, but with 'startsWith("www.google.")' to cover all the other Google domains.
But I still wonder why it covers markers. Probably my tile replacement kicks in on some requests where it shouldn't. Probably this is the right opportunity to have a deeper look into the parameter syntax used by Google. I guess the same issue could happen on other websites where similar markers are used.
from osm-everywhere.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osm-everywhere.