Icons not properly visible on some static themes about undoclosetab

[Henry47a]

Since my favorite theme Dark Fox No Logo got an update yesterday, the undoclosetab icon is no longer displayed correctly.

I made some tests with the theme on Windows 7 and Firefox 66.0.5 (64-bit)

With theme version 2.0 and undoclosetab 4.4.3 only a black arrow is displayed.
With theme version 1.0 and undoclosetab 4.4.3 the icon is displayed correctly.
With theme version 2.0 and undoclosetab 4.1.3 the icon is also displayed correctly.

[M-Reimer]

Removing transparency is only one issue.
The major problem is that I don't get notified about the theme change at all.
--> Upstream bug
https://bugzilla.mozilla.org/show_bug.cgi?id=1494620

Edit: New upstream bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1492145

[rugk]

Hmm… why do you even manually handle theme changes?

These two lines should do it all, AFAIK:
https://github.com/M-Reimer/undoclosetab/blob/master/manifest.json#L29-L30

Firefox automatically determines whether the theme is black or white and switches to the appropriate icon. (unless you overwrite that via JS, of course) BTW, also why 19px?? 😮

[M-Reimer]

These lines don't help that much.
IMHO the whole idea behind this "black and white" thing is obsolete since https://color.firefox.com/
My current "recolor" code works well with "Firefox Color" but fails with so-called "lightweight themes"
Even without my "recolor" code you'll find themes on AMO where the icon is not visible as the coloring doesn't fit.

I use 19px as this was taken from the Firefox sourcecode at some time.
The size doesn't matter anyway as Firefox renders dynamically from SVG.

Currently Mozilla makes it really difficult for developers to create toolbar icons that fit well with the existing ones... 😢

[rugk]

Well… if the correct color is not correctly detected then this is an issue of Firefox.
But you well likely always have themes that may have a light "edge" where your icon symbol is and are otherwise pretty dark. I see nothing you can do here, as an add-on author.

[rugk]

A thing like https://discourse.mozilla.org/t/use-theme-colors-for-svg-favicons/29165 would likely fix the problem properly…

[M-Reimer]

https://bugzilla.mozilla.org/show_bug.cgi?id=1492145 has been accepted.
I really hope they'll also cover "static themes" with their fix.

[geniuszxy]

@M-Reimer a part of the icon disappears since upgrade Firefox to 65.0 if I use a custom theme.

ThemeUpdated is invoked, but the output seems lost some data.
.

[M-Reimer]

Interesting. Please also add a link to the theme (addons.mozilla.org link).

[M-Reimer]

Did a short test with "Firefox Color" (my common testcase for dynamic themes) and it works there.
I really need the theme and maybe this is a "Windows only" problem which I couldn't debug at all...

[geniuszxy]

@M-Reimer , the icon works well with Firefox Color, my problem is occured with other static themes download from addons site, such as this one: https://addons.mozilla.org/en-US/firefox/addon/modern-sunstet-v2/?src=search

[M-Reimer]

Fixed:
140187a

[M-Reimer]

Thanks for reporting. This is another missing color name which has to be checked on theme update. Fixed by d806125
Will be part of the next release.

[M-Reimer]

I've published 4.4.4 with another fix. In this case I not only added all possible color names that seem to influence the icon color but I also added a fallback to not re-render the icon if no usable color at all can be found in the used theme.

If there are other themes with problems, then please open a new Issue and add a link to the problematic theme.

[M-Reimer]

I've published 4.4.4 with another fix. In this case I not only added all possible color names that seem to influence the icon color but I also added a fallback to not re-render the icon if no usable color at all can be found in the used theme.

If there are other themes with problems, then please open a new Issue and add a link to the problematic theme.