Comments (15)
Since my favorite theme Dark Fox No Logo got an update yesterday, the undoclosetab icon is no longer displayed correctly.
I made some tests with the theme on Windows 7 and Firefox 66.0.5 (64-bit)
With theme version 2.0 and undoclosetab 4.4.3 only a black arrow is displayed.
With theme version 1.0 and undoclosetab 4.4.3 the icon is displayed correctly.
With theme version 2.0 and undoclosetab 4.1.3 the icon is also displayed correctly.
from undoclosetab.
Removing transparency is only one issue.
The major problem is that I don't get notified about the theme change at all.
--> Upstream bug
https://bugzilla.mozilla.org/show_bug.cgi?id=1494620
Edit: New upstream bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1492145
from undoclosetab.
Hmm… why do you even manually handle theme changes?
These two lines should do it all, AFAIK:
https://github.com/M-Reimer/undoclosetab/blob/master/manifest.json#L29-L30
Firefox automatically determines whether the theme is black or white and switches to the appropriate icon. (unless you overwrite that via JS, of course) BTW, also why 19px?? 😮
from undoclosetab.
These lines don't help that much.
IMHO the whole idea behind this "black and white" thing is obsolete since https://color.firefox.com/
My current "recolor" code works well with "Firefox Color" but fails with so-called "lightweight themes"
Even without my "recolor" code you'll find themes on AMO where the icon is not visible as the coloring doesn't fit.
I use 19px as this was taken from the Firefox sourcecode at some time.
The size doesn't matter anyway as Firefox renders dynamically from SVG.
Currently Mozilla makes it really difficult for developers to create toolbar icons that fit well with the existing ones... 😢
from undoclosetab.
Well… if the correct color is not correctly detected then this is an issue of Firefox.
But you well likely always have themes that may have a light "edge" where your icon symbol is and are otherwise pretty dark. I see nothing you can do here, as an add-on author.
from undoclosetab.
A thing like https://discourse.mozilla.org/t/use-theme-colors-for-svg-favicons/29165 would likely fix the problem properly…
from undoclosetab.
https://bugzilla.mozilla.org/show_bug.cgi?id=1492145 has been accepted.
I really hope they'll also cover "static themes" with their fix.
from undoclosetab.
@M-Reimer a part of the icon disappears since upgrade Firefox to 65.0 if I use a custom theme.
ThemeUpdated is invoked, but the output seems lost some data.
.
from undoclosetab.
Interesting. Please also add a link to the theme (addons.mozilla.org link).
from undoclosetab.
Did a short test with "Firefox Color" (my common testcase for dynamic themes) and it works there.
I really need the theme and maybe this is a "Windows only" problem which I couldn't debug at all...
from undoclosetab.
@M-Reimer , the icon works well with Firefox Color, my problem is occured with other static themes download from addons site, such as this one: https://addons.mozilla.org/en-US/firefox/addon/modern-sunstet-v2/?src=search
from undoclosetab.
Fixed:
140187a
from undoclosetab.
Thanks for reporting. This is another missing color name which has to be checked on theme update. Fixed by d806125
Will be part of the next release.
from undoclosetab.
I've published 4.4.4 with another fix. In this case I not only added all possible color names that seem to influence the icon color but I also added a fallback to not re-render the icon if no usable color at all can be found in the used theme.
If there are other themes with problems, then please open a new Issue and add a link to the problematic theme.
from undoclosetab.
I've published 4.4.4 with another fix. In this case I not only added all possible color names that seem to influence the icon color but I also added a fallback to not re-render the icon if no usable color at all can be found in the used theme.
If there are other themes with problems, then please open a new Issue and add a link to the problematic theme.
from undoclosetab.
Related Issues (20)
- Updated translations for 'ptbr'
- Updated translations for 'zh_CN': zh_CN
- [Feature request] Option for left-click to open the context menu HOT 1
- Firefox policies support HOT 13
- Add Support for Manage Extension Shortcuts to allow shortcut to activate an undo HOT 3
- Empty closed tabs list sometimes HOT 15
- wrong issue HOT 2
- List of recently closed tabs missing from right click menu HOT 1
- [New addon] Closed tab notifier HOT 3
- After each start, the list is empty HOT 6
- The “Web” icon in Undo Close Tab context menu is outdated HOT 1
- Right click sporadically stops working HOT 1
- in firefox 113 the toolbar button right click no longer works. HOT 2
- is there a different version of this extension for closing tab instead undo close tab?
- [Idea] Suggestions to change extension icon HOT 8
- [Idea] keyboard short for using undo close functionality HOT 1
- New translations for 'it': Italian (Italiano)
- "Recently closed windows" greyed out after restart HOT 3
- Can't find Icon unduclosetab sinds firefox 120.01 HOT 3
- Use Proton folder icon for "More Entries" HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from undoclosetab.