Do not pass -l%u to ssh in sshcmd.c if not explicitly defined about pdsh

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Thanks for opening this request. I can't think of any reason not to leave
-l%u off the default ssh args now that the code adds it when necessary
(i.e. when ruser != luser)

Can you try the attached patch?

Original comment by [email protected] on 4 Oct 2011 at 10:30

Attachments:

• 0001-sshcmd-Remove-l-u-from-default-ssh-args.patch

[GoogleCodeExporter]

Hi,

I applied the patch on the (clean) source, and recompiled the code. Now it 
works as described above. 

I tested the following cases:

1. ruser != luser but ruser defined in ssh config
Works well.

2. ruser != luser but ruser NOT defined in ssh config
Works as expected. Explicit -l is needed at pdsh command line to log in.

3. ruser != luser but ruser defined in ssh config, AND overriding it with pdsh 
-l option
Works as expected, pdsh's -l overrides ssh config. Without the explicit pdsh -l 
it reads the username from the ssh config.

4. Putting back the -l%u in the PDSH_SSH_ARGS environment variable brings back 
the old behaviour of handling the username.

Is there any possibility to apply this patch on the future releases? Let's say 
2.28 ;)

Regards,

Vish

Original comment by [email protected] on 5 Oct 2011 at 9:09

[GoogleCodeExporter]

Hi,

in addition:

5. Tested using dshgroups modules, with -g option.

Original comment by [email protected] on 5 Oct 2011 at 9:11

[GoogleCodeExporter]

Yes, I plan to add this to pdsh-2.28

Original comment by [email protected] on 5 Oct 2011 at 8:41

[GoogleCodeExporter]

This issue was updated by revision aabc5bff1a77.


The -l%u argument to ssh is now added when remote username is
different from local username, so it no longer needs to be
in the default argument list.

Original comment by [email protected] on 19 Oct 2011 at 5:41

[GoogleCodeExporter]

Original comment by [email protected] on 2 Nov 2011 at 11:07

• Changed state: Fixed