Allow more levels of directory recursion in rpdcp server about pdsh

[GoogleCodeExporter]

Nicely done.
I'll apply this for the next pdcp release.

Should we separately add a test for pdcp to ensure a minimum level of recursion
depth?

Maybe undoing the recursion would be a good idea?

Original comment by [email protected] on 15 Feb 2012 at 5:06

• Changed state: Accepted

[GoogleCodeExporter]

Thanks.

I did some more tests.  pdcp (pushing to multiple nodes) goes out to at least 
1000 levels.  rpdcp (pulling from multiple nodes) goes out to 83 levels on 
ppc64 with my patch.  Somehow the two are quite different.  Adding tests for 
either or both that explicitly test recursion depth to some reasonable value 
makes sense to me.

Undoing the recursion would be nice for at least a few reasons.  One, it would 
be a good excuse to cleanup the _sink() code.  Two, it would handle a much 
deeper directory tree.  Three, if it does fail, a better error message of "out 
of memory" could be given rather than SEGV.  However, I would put it as a low 
priority enhancement, since as far as I know, no one noticed the old limit of 
14 levels on x86_64, so the new, much larger limits are even less likely to be 
an issue in practice.

Original comment by [email protected] on 15 Feb 2012 at 5:51

[GoogleCodeExporter]

Your patch was applied in commit 5a8411b83ff

Original comment by [email protected] on 16 Feb 2012 at 12:02