GithubHelp home page GithubHelp logo

Comments (4)

Lukasz4598PL avatar Lukasz4598PL commented on September 8, 2024 1

it doesn't seem to totaly remove drops,I killed five enderman and got nothing after that i killed a few more and got normal drops
.

from ma-enchants.

Xetaxheb avatar Xetaxheb commented on September 8, 2024

After using my weapons without it, I can say it significantly screws up drop rates on many many things. The main thing that somehow sneaks by is elementalcraft shards. Most other drops seem to be significantly lowered or outright removed.

from ma-enchants.

DerekM07 avatar DerekM07 commented on September 8, 2024

I noticed the same thing with Ma-Enchants and Reliquary and assumed it was because lifesteal and sweeping edge were incompatible together. I didn't test extensively, but I believe that only the primary target was counting as a player kill and thus qualifying for the Reliquary drop chance.

from ma-enchants.

SiverDX avatar SiverDX commented on September 8, 2024

My assumption is that this is the problem (if the damage kills the mob):

This also breaks the Wisdom enchant of this mod:

if (event.getEntity() != event.getAttackingPlayer()) return;

I'm not sure why Lifesteal deals extra damage but DamageSource.playerAttack(player) should maybe be used instead

from ma-enchants.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.