Issue with Disabling Password Changes about adpassmon

[pmbuko]

Thanks for letting us know. Are you using release 2.20.12?

[dire-alpaca]

Yes, I was testing using 2.20.12.

Thanks!

[macmule]

@an-Alpaca Thanks.. I'll have a look at this this week

[matt-cahill]

I'm also seeing the same behaviour on 10.11.3 using 2.20.14 (130)

[matt-cahill]

Setting pwPolicyURLButtonTitle to a value using defaults write restores the functionality. Possibly this issue is similar #45

[pmbuko]

That's good to know. I think we just need to make the disable part more robust.

[matt-cahill]

Seems to be two seperate but intertwined issues.

Firstly I can't find pwPolicyURLButton in the code, I think this is just a typo in the docs. Should be pwPolicyURLButtonTitle

Secondly if either pwPolicyURLButtonTitle or pwPolicyURLButtonURL are not set then pwPolicyUpdateExternal never gets set in the block starting at line 1235 and thus the password update window is displayed at line 940 even if allowPasswordChange is set to false.

[matt-cahill]

I updated the wiki regarding the defaults write for pwPolicyURLButtonTitle

[dire-alpaca]

Just did some further testing and found the prompts seem to work properly now with the different config option pwPolicyURLButtonTitle. Thanks @matt-cahill for the code digging!

Settings set:

    pwPolicy = "At SMS, Staff are required to have a password that is at least 8 characters long. Students are required at least 4 characters. Please visit the Account Portal to change/reset your password.";
    pwPolicyButton = Okay;
    pwPolicyURLBrowser = "Google Chrome";
    pwPolicyURLButtonTitle = "SMS Account Portal";
    pwPolicyURLButtonURL = "https://accounts.stmarg.ca";
    selectedBehaviour = 2;

I do believe further robustness is require on some of the settings. As @matt-cahill said above, you have to set many options in order to stop the dialogs from coming up.

[macmule]

Merged, will be in next release.