Comments (3)
See the documentation for std::make_unique.
Here's the relevant quote:
[std::make_unique] Constructs an array of the given dynamic size. The array elements are value-initialized. ...
As a reminder, value-initialization for int
means zeroing.
from bvh.
Ah ok that makes sense, thanks. I was assuming (mistakenly) that you are using unique_ptr's to avoid value initializing the array. So the reason to use a unique_ptr instead of a std::vector is to communicate that the arrays dont change in length?
from bvh.
First of all, as you noticed, the arrays don't change in length, so there's no need to carry around a capacity
field. Second, the size
field of std::vector
would also be redundant here: Those arrays have the same size as the number of nodes in the BVH.
To sum things up, this at the same time conveys the idea that the size does not change, and as an additional bonus makes the generated machine code a bit simpler and the class that contains those arrays thinner (not that this is a particular bottleneck, but still, it's a nice thing to have).
from bvh.
Related Issues (20)
- Your code is building fine on MSYS2 MINGW64 HOT 1
- Two tests need pthread to compile on linux HOT 2
- Library does not handle rays parallel to axes HOT 5
- Identifiers near and far in bvh.h cause issues when precompiled headers are used HOT 3
- config.min_leaf_size > 1 Leads to assertion failure HOT 1
- What is the use case? is it slower than embree? HOT 1
- Cancel build +progress monitor HOT 4
- Consider adding to vcpkg HOT 1
- Ability to re-use BVH allocations? HOT 1
- Adding and Removing elements HOT 1
- Optimize node index serialization HOT 1
- Clarify what primitive data leaf nodes actually store HOT 1
- Potential bug in traversal functions HOT 1
- Possible stale pointer usage in extract_bvh()? HOT 4
- Sweep SAH builder HOT 4
- ReinsertionOptimizer sometimes gets stuck in an infinite loop HOT 16
- Updating node positions and sizes? HOT 3
- Python bindings available? HOT 3
- Fail to build C API with clang HOT 1
- warning C4267: conversion from 'size_t' to 'unsigned int', possible loss of data HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bvh.