GithubHelp home page GithubHelp logo

Comments (9)

mafredri avatar mafredri commented on May 24, 2024

Thanks for the sample code, I tried running it but I can't spot the problem. To me, the Chrome screenshot looks better / more correct (dehtml seems to render incorrectly):

screen shot 2018-03-17 at 14 59 27

What should I be looking for? PS. Using Chrome Beta (66) on macOS.

from cdp.

s3rj1k avatar s3rj1k commented on May 24, 2024

@mafredri bottom page, for me site header is doubled
proper footer should look like this
https://prnt.sc/isg5t0

using Chromium 65.0.3325.146 on Linux

from cdp.

mafredri avatar mafredri commented on May 24, 2024

Hmm, I can't see the doubled site header, but it looks like pikabu.ru uses infinite scrolling. Most likely that has something to do with the footer looking incorrect.

E.g. maybe just as Chrome sets the page viewport, the site starts loading more content.

Not sure how to deal with that, maybe:

  • Try to disable JavaScript, if possible
  • Analyze page source and disable infinite scrolling (e.g. replace JS function)
  • Use network interception before taking the screenshot and block network requests

Maybe this also classifies as a headless bug? Might be worth reporting to the headless mailing list and/or reporting on the chromium bug tracker.

from cdp.

s3rj1k avatar s3rj1k commented on May 24, 2024

can you provide example on "Use network interception before taking the screenshot and block network requests" ?

from cdp.

s3rj1k avatar s3rj1k commented on May 24, 2024

lol, with Google Chrome 66.0.3359.33 beta everything is superb
still would be nice to test with block network requests

from cdp.

mafredri avatar mafredri commented on May 24, 2024

Heh 😅, updating Chrome often helps (esp. when using headless).

You can see some example uses of interception in #40, #36, #32. Although, some of those might be a bit outdated since Chrome changed the network interception API (I believe #40 at least is up-to-date).

But most likely you just need to begin interception, there's probably no need to "reply" to (e.g. continue) them.

from cdp.

s3rj1k avatar s3rj1k commented on May 24, 2024

@mafredri can I just use c.Page.StopLoading(ctx) instead of interception?

from cdp.

mafredri avatar mafredri commented on May 24, 2024

I'm not an expert, but judging from the documentation I don't think it does anything to prevent future network requests.

from cdp.

s3rj1k avatar s3rj1k commented on May 24, 2024

hmm, that could be true, still has to be enough for quick screenshot after stopping page load.

that for your support, closing this one. 👍

from cdp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.