Comments (11)
Hello! I would like to take ownership of this issue and work on resolving it. Could you please assign it to me? Thank you!
from catalog.
Hey @aryanraj60 go for it! Please first join our slack channel: https://join.slack.com/t/mirrorful/shared_invite/zt-1ps2xtxh0-2NaixFfFzSKZbr5gw_AHfA
And after forking the repo, here's how you can get set up:
➜ mirrorful git:(main) ✗ cd packages/mirrorful/editor
➜ mirrorful git:(main) ✗ git checkout -b "aryanraj/issue-58"
➜ mirrorful git:(paul/issue-53) ✗ yarn; cd editor; yarn; cd .. # install packages
➜ mirrorful git:(paul/issue-53) ✗ yarn run local # runs mirrorful locally
$ rm -rf ./dist; tsc --build; cross-env NODE_ENV=development node ./dist/cli/index.js
Running Mirrorful version: 2.0.19
Starting Mirrorful in /Users/zeus/code/mirrorful/packages/mirrorful.
Visit: http://localhost:5050/
Inside your project, you can run:
yarn run mirrorful
to start the visual editor at any time 🚀
Then, you can make changes in code, and once done, open a PR for your changes. Let us know if any questions!
from catalog.
Hi @aryanraj60 are you working on this? Let us know!
from catalog.
Can I take this up?
from catalog.
Sure go for it @iamoghenerukevwe !
from catalog.
Does it need to be assigned to me?
from catalog.
Going to clear the assignments, any one is welcome to open a PR for this!
from catalog.
@iamoghenerukevwe go for it!
from catalog.
I'm currently looking into this as well and the issue is that the nameThatColor
function is not able to generate a name for a specific combination of h, l, s
. Would it be possible to get more clarity on what the current checks are based on? -
if (s <= 0.1 && l >= 0.9) {
return 'White'
} else if (l <= 0.15) {
return 'Black'
} else if ((s <= 0.1 && l <= 0.7) || s === 0) {
return 'Gray'
} else if ((h >= 0 && h <= 15) || h >= 346) {
return 'Red'
} else if (h >= 16 && h <= 35) {
if (s < 0.9) {
return 'Brown'
} else {
return 'Orange'
}
} else if (h >= 36 && h <= 54) {
if (s < 0.9) {
return 'Brown'
} else {
return 'Yellow'
}
} else if (h >= 55 && h <= 165) {
return 'Green'
} else if (h >= 166 && h <= 260) {
return 'Blue'
} else if (h >= 261 && h <= 290) {
return 'Purple'
} else if (h >= 291 && h <= 345) {
return 'Pink'
}
return 'Unknown'
from catalog.
Hey @ktra99! This block of code is effectively trying to capture all the different combinations of h
,l
and s
and maps them to a color name. I think the best way to debug this would actually be to write a for
loop that goes through every combination of h
, l
, s
to determine what ranges are missing from this block (that was pretty much copied from Stack Overflow). For example,
for (let s = 0; s < 1; s += 0.1){
for (let h = 0; h < 360; h += 1){
for (let l = 0; l < 0.1; l += 0.1){
if ( nameThatColor(h, s, l) === 'Unknown' ){
console.log(h, s, l)
}
}
}
}
from catalog.
Linking this discussion to this PR opened by Paul: #182
from catalog.
Related Issues (20)
- Enter on color picker should save the value even when still in focus HOT 5
- Bug when deleting multiple colors at once HOT 1
- Allow ability to change palette colors on onboarding screen HOT 1
- Mobile Responsiveness: Center Align the 'You are not logged in' alert HOT 1
- Mobile Responsiveness: Sidebar to be closed be default on mobile when page loads HOT 5
- Mobile Responsiveness: Unable to rename colors HOT 3
- Mobile Responsiveness: Hanging Sidebar on iPhone SE and small mobile devices
- Mobile Responsiveness: Toggle Dark/Light mode button doesn't work HOT 1
- Move nextjs app (apps/web) back to using pages router instead of app router HOT 2
- Add darkmode button to the top HOT 2
- Fix typo in contributing guide
- 🐛 The link to the docs in the github description is wrong HOT 1
- Add support for PrimeReact
- Add support for NextUI
- Add support for Semantic UI
- Add support for Daisy UI
- Add a page for each component
- Change Magic Patterns logo on README file HOT 1
- Radix not loading all components
- Add support for Material UI HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from catalog.