GithubHelp home page GithubHelp logo

Comments (68)

DanGLES3 avatar DanGLES3 commented on July 3, 2024 1

Love this module but could you please fix those tiny white rectangles? Here's a picture of what I mean:

Screenshot_20221017-181021

If you're using the Gcam lag fix option that's just a common side effect because to fix the Gcam lag a fraction of the navigation bar needs to be visible

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024 1

It's all good, no need for the theme, I can live with the rectangles (or the lag in the camera app tbh, I don't take pictures that often). I'll try reaching out to the GCam Mod devs.

Thanks for the info!

Best of luck to you, if you manage to get that fixed on GCam Mods be sure to notify me, I'd love to know that

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024 1

It's all good, no need for the theme, I can live with the rectangles (or the lag in the camera app tbh, I don't take pictures that often). I'll try reaching out to the GCam Mod devs.

Thanks for the info!

Also tbh I'm already transitioning my module to substratum as it's just easier to maintain and way more reliable than my module could ever hope to be

Only reason why the module works so well now is because I'm using Android 12+ Fabricated Overlays feature however that limits what I can do to tweak the navigation bar (can't hide the buttons when the keyboard is opened for example) and that can't be applied to Android 10-11, not to mention it makes my module's installer even more messy than I'd like

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024 1

Haha dude it's no worries at all, I was expecting something a few days from now, not a few hours.

Thanks so much! This is immensely helpful.

Be sure to tell me if it works out for you

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024 1

Where does the setting live? Sorry I'm unfamiliar when it comes to system settings.

Where every other system setting lives /data/system/user/0/

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024 1

And I did do this: "Using this command in a .nk file inside data/adb/post-fs-data.d: resetprop qemu.hw.mainkeys 1".

Would that modify any read-only partitions in any way? I'm assuming /data/... is not read only.

/Data is where every user setting, installed app and whatnot is stored, and no, resetprop commands do not tamper with any partitions whatsoever as that's all done in memory

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Actually I resolved the issue by hiding the navbar via an entirely different way:
Using this command in a .nk file inside data/adb/post-fs-data.d: resetprop qemu.hw.mainkeys 1

I haven't noticed any issues with the Gcam using this method to hide the navbar. (I'm using Vivid nav gestures for navigation)

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Actually I resolved the issue by hiding the navbar via an entirely different way: Using this command in a .nk file inside data/adb/post-fs-data.d: resetprop qemu.hw.mainkeys 1

I haven't noticed any issues with the Gcam using this method to hide the navbar. (I'm using Vivid nav gestures for navigation)

Tbh the issue with Gcam is slow mode switching, if that doesn't happen to you then with this method then great

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Oh shit, I didn't know that's what was meant by Gcam issue. Yeah, I'm definitely experiencing lag with my method. Why does that happen?

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Oh shit, I didn't know that's what was meant by Gcam issue. Yeah, I'm definitely experiencing lag with my method. Why does that happen?

Gcam (and Google's Markup/Screenshot editor) for whatever reason freak the f out if the navigation bar is not there (i legit have no clue why), only way to fix it is by keeping a fraction of the navigation bar still visible (with the Gcam fix)

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Yeah it's really weird, because Snapchat and other camera apps work fine. Has the issue been reported to Google?

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Yeah it's really weird, because Snapchat and other camera apps work fine. Has the issue been reported to Google?

Thing is, this issue only happens in a configuration (hiding the navbar) that simply doesn't exist on a stock pixel (as Gcam is only officially available there)

So i don't think Google would consider this a valid report as this only happens when you tamper/mod a Pixel device or use Gcam on a third party device (with this tweak) which Google doesn't support

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

That's a shame. For what it's worth, I submitted an issue on it anyways. Has any other developer (besides Google) looked into this? Perhaps someone from XDA?

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

That's a shame. For what it's worth, I submitted an issue on it anyways. Has any other developer (besides Google) looked into this? Perhaps someone from XDA?

None that I could find last time I've looked into it, for what's worth seems most people either don't notice or simply don't care about this issue enough to report/investigate it

I guess you could try reporting this to the developers of famous GCam mods to see if they can do anything at least on their modded APKs

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

That's a shame. For what it's worth, I submitted an issue on it anyways. Has any other developer (besides Google) looked into this? Perhaps someone from XDA?

As a workaround I could make a substratum theme to make those 3 lines disappear (i assume you're using 3 button navigation right?) by making an empty navigation bar layout, navbar would still exist but it would have no buttons

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

It's all good, no need for the theme, I can live with the rectangles (or the lag in the camera app tbh, I don't take pictures that often). I'll try reaching out to the GCam Mod devs.

Thanks for the info!

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Actually the thought just occurred to me, do the rectangles have to be white? Can they be transparent?

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Actually the thought just occurred to me, do the rectangles have to be white? Can they be transparent?

Are you using 3 button navigation?

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Yep

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Yep

Then as i said previously i can make a substratum theme that creates a blank navigation bar layout without buttons, i'll need some time tho as i'm busy rn

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Oh ok no rush. Thank you for taking the time to do this!

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Oh ok no rush. Thank you for taking the time to do this!

app-release.zip

Here it is, use Substratum Lite btw, on the SystemUI option choose the hide keyboard buttons feature, see if it works out for you

Apologies for the long delay btw

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Haha dude it's no worries at all, I was expecting something a few days from now, not a few hours.

Thanks so much! This is immensely helpful.

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

I'm on Android 13. Should I just get substratum lite off of the app store?

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

I'm on Android 13. Should I just get substratum lite off of the app store?

Yeah

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Substratum Lite crashed a short while after I launched it and gave it root permission.

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Substratum Lite crashed a short while after I launched it and gave it root permission.

Try clearing its data and see if it works, I've seen other people on Android 13 use it just fine

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

That fixed it. Do I have to uninstall your magisk module before testing this out?

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

That fixed it. Do I have to uninstall your magisk module before testing this out?

As long as you just enable the option in the System UI you should have no need to

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Okay so unfortunately I uninstalled the Magisk module before using your substratum theme, but that's okay because the Android System portion behaves as expected with the nav bar mode set to "Fullscreen - GcamLagFix". However, even with the SystemUI set to "HidePill/Keyboard Buttons" I still see the three small white rectangles at the bottom.

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Okay so unfortunately I uninstalled the Magisk module before using your substratum theme, but that's okay because the Android System portion behaves as expected with the nav bar mode set to "Fullscreen - GcamLagFix". However, even with the SystemUI set to "HidePill/Keyboard Buttons" I still see the three small white rectangles at the bottom.

Just to be sure, you've specifically chosen/installed the Hide Keyboard Buttons option right?

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Yep, installed the Hide keyboard option, then I rebooted, then I enabled it and it had no effect.

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

FWIW, the SystemUI overlay name in Substratum is in Red, while the Android System one is green

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

FWIW, the SystemUI overlay name in Substratum is in Red, while the Android System one is green

If it's red it's because it's disabled

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

I see. However I found out that red means "disabled - invalid overlay" so I'm not even able to enable it.

Screenshot_20221021-044007
Screenshot_20221021-044001

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Ignore the selections

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Ignore the selections

Gimme a minute

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Ignore the selections

app-release_src (1).zip

You'll have to uninstall the current APK, I'm not on my PC rn so i can't properly sign APKs

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Still facing the same issue. I'm able to hide the navbar and buttons but not the rectangles. SystemUi overlay is still red/invalid

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Still facing the same issue. I'm able to hide the navbar and buttons but not the rectangles. SystemUi overlay is still red/invalid

Did you reinstall the overlays and reboot?

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Yep

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Yep

Weird, overlays don't show as red here, when installing the system UI overlay, do any errors show up?

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Yep

Btw i think i see the issue, you don't seem to be selecting anything in the system UI option (tap on it and explicitly choose the hide keyboard buttons option, the hidepill/keyboard buttons option is just description text, it's not an actual option)

Even the manage option just shows a blank system UI overlay with no description of it's option

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Ahh I see. Ok so I set it to hide buttons and then rebooted and now everything is green. I enabled both, but I can still see the white rectangles.

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Ahh I see. Ok so I set it to hide buttons and then rebooted and now everything is green. I enabled both, but I can still see the white rectangles.

Try the previous APK now, see if it works, if not I'll ask you for you to wait until tomorrow as it's now 6am and I'm severely exhausted rn

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Oh jeez, yeah no need to get this done right now, please rest lol.
I have just tried the old APK and selected options for both. Everything is green and I still see the white rectangles.

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Oh jeez, yeah no need to get this done right now, please rest lol. I have just tried the old APK and selected options for both. Everything is green and I still see the white rectangles.

Yeah, gimme a sec, i've got a better solution just for ya, i'll need you to enable gesture navigation tho

i'll then make the theme disable the bottom gestures (to disable the back gestures just open the app from the app drawer and disable it from there, can't really do that within substratum), so you'll be able to use any other gesture app in its place

Is that good for you?

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Oh jeez, yeah no need to get this done right now, please rest lol. I have just tried the old APK and selected options for both. Everything is green and I still see the white rectangles.

app-release.zip

You'll need to enable the no gestures option in the Android System (make sure to also install the fullscreen overlay on it)

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Yes this would work. But hmm I don't see a "no gestures" option for Android System. I do see (and have disabled) the back gestures from within your APK.

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Also would I use the "hide pill" option now for SystemUI?

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Yes this would work. But hmm I don't see a "no gestures" option for Android System. I do see (and have disabled) the back gestures from within your APK.

Gimme a sec, guess I've sent the wrong apk

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Also quick question: how do I reenable the back gesture after disabling it from within your app? I uninstalled your APK but forgot to turn it back on and now the left side of my screen can't back gesture, even after reboot.

Funnily enough, this actually fixed one of the reasons I didn't like the Pixel 7 Pro's gestures in the first place, which is that apps with a hamburger menu can't use the "swipe in from left to pull in the menu" gesture.

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Also would I use the "hide pill" option now for SystemUI?

app-release2.zip

No Gestures should show up now

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Also quick question: how do I reenable the back gesture after disabling it from within your app? I uninstalled your APK but forgot to turn it back on and now the left side of my screen can't back gesture, even after reboot.

Funnily enough, this actually fixed one of the reasons I didn't like the Pixel 7 Pro's gestures in the first place, which is that apps with a hamburger menu can't use the "swipe in from left to pull in the menu" gesture.

Just reinstall the app and turn it back on from there, and yeah the disable back gesture was originally designed for the use of hamburger menus

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

That did it, thanks so much! No Gcam app lag, I'm able to use the vivid gestures I configured and everything works!

Out of curiosity, how was your app disabling the back gesture from within the APK? When I granted it root access, what was it modifying?

Because lowkey, if I could just disable the left side back gesture, the native Pixel gestures work perfectly.

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

That did it, thanks so much! No Gcam app lag, I'm able to use the vivid gestures I configured and everything works!

Out of curiosity, how was your app disabling the back gesture from within the APK? When I granted it root access, what was it modifying?

Because lowkey, if I could just disable the left side back gesture, the native Pixel gestures work perfectly.

Well since Android 11, Android determines the sensitivity of the back gesture based on a settings value (back_gesture_inset_scale_right and back_gesture_inset_scale_left), turns out setting either to a negative value (such as -1) basically disables the back gesture for that side

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

That did it, thanks so much! No Gcam app lag, I'm able to use the vivid gestures I configured and everything works!

Out of curiosity, how was your app disabling the back gesture from within the APK? When I granted it root access, what was it modifying?

Because lowkey, if I could just disable the left side back gesture, the native Pixel gestures work perfectly.

Tbh, if all you want is to disable the back gestures and use the native system gestures, just disable the back gesture on the left for hamburger menus from within the app

And if you wish to have the gesture navigation bar hidden then simply keep the substratum overlays enabled and disable the no gestures one

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Got it. I was just wondering if I could do this without any apps installed for cleanliness sake.

For example, I used "resetprop qemu.hw.mainkeys 1" to hide the navbar (which caused the Gcam bug). Is there any command like that that I could put in a file to disable the left side back gesture? And also one to hide the gesture nav bar?

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Got it. I was just wondering if I could do this without any apps installed for cleanliness sake.

For example, I used "resetprop qemu.hw.mainkeys 1" to hide the navbar (which caused the Gcam bug). Is there any command like that that I could put in a file to disable the left side back gesture? And also one to hide the gesture nav bar?

Tbh, after disabling the back gesture you can just remove the app, it doesn't need to be there anymore after you disable the back gesture

As for hiding the gesture nav bar, that needs a theme or a module

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Ah I see. I'm curious though, how is the app able to persist in its disabling of the back gesture even after uninstall?

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Ah I see. I'm curious though, how is the app able to persist in its disabling of the back gesture even after uninstall?

It changes a system setting and that setting persists through reboots like any other system setting

if you're that curious it basically runs the following command as root

settings put secure back_gesture_inset_scale_left (or right) -1

and to reenable the back gesture it runs

settings delete secure back_gesture_inset_scale_right
settings delete secure back_gesture_inset_scale_left

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Ah cool. Thanks for the info! This whole thing really made my life a lot easier.

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Ah cool. Thanks for the info! This whole thing really made my life a lot easier.

Happy to help :)

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Hey man, just wanted to clarify something. Does the system setting you tweak modify the /system partition in any way?

I followed this guide by the Magisk creator and he states: "NOTE: In order to apply OTAs, you HAVE to make sure you haven’t modified and read-only partitons yourself (such as /system or /vendor) in any way. Even remounting the partition to rw will tamper block verification!!"

I'm asking because I followed the guide and now my phone is giving me a "Your device is corrupt" warning and is stuck on the Google logo on reboot.

from hidenavbar.

DanGLES3 avatar DanGLES3 commented on July 3, 2024

Hey man, just wanted to clarify something. Does the system setting you tweak modify the /system partition in any way?

I followed this guide by the Magisk creator and he states: "NOTE: In order to apply OTAs, you HAVE to make sure you haven’t modified and read-only partitons yourself (such as /system or /vendor) in any way. Even remounting the partition to rw will tamper block verification!!"

I'm asking because I followed the guide and now my phone is giving me a "Your device is corrupt" warning and is stuck on the Google logo on reboot.

The setting in no way needs to tamper with the system partition, it's a regular setting like any other

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Where does the setting live? Sorry I'm unfamiliar when it comes to system settings.

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

And I did do this: "Using this command in a .nk file inside data/adb/post-fs-data.d: resetprop qemu.hw.mainkeys 1".

Would that modify any read-only partitions in any way?
I'm assuming /data/... is not read only.

from hidenavbar.

pritster5 avatar pritster5 commented on July 3, 2024

Ok perfect, thank you for explaining. This helps me narrow it down and at least this stuck bootup isn't a fault of my own haha.

from hidenavbar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.