GithubHelp home page GithubHelp logo

Comments (10)

punker76 avatar punker76 commented on June 8, 2024 1

@timunie Generating the path data directly is not possible, because of the different source of the icons. That’s why I didn’t publish my converter.

@MarkIvanDev I will try and look if the resx can help here.

from mahapps.metro.iconpacks.

punker76 avatar punker76 commented on June 8, 2024

@MarkIvanDev Idk exactly why this happens. I can see that the XamlTypeInfo for Debug is different to Release but Idk why...

from mahapps.metro.iconpacks.

punker76 avatar punker76 commented on June 8, 2024

@MarkIvanDev If I disable "Compile with .NET Native tool chain" the app runs fine. That's the reason why I'm hate UWP!

image

from mahapps.metro.iconpacks.

MarkIvanDev avatar MarkIvanDev commented on June 8, 2024

Yes. It only runs when not compiling with .NET Native toolchain. I have also checked what is different with the icons with bugs from the ones that work correctly, and nothing stands out that might cause the problem. Although, I have read somewhere that there is a limit to the length of a string in a library. Maybe it is having problems with the massive icon data for those icon packs?

from mahapps.metro.iconpacks.

punker76 avatar punker76 commented on June 8, 2024

@MarkIvanDev

Although, I have read somewhere that there is a limit to the length of a string in a library. Maybe it is having problems with the massive icon data for those icon packs?

But it's working on WPF. You can see it in action with the IconPacks browser.

from mahapps.metro.iconpacks.

MarkIvanDev avatar MarkIvanDev commented on June 8, 2024

@punker76

But it's working on WPF. You can see it in action with the IconPacks browser.

Yes. Maybe the string limitation is only enforced in .NET Native? Or .NET Native has a problem with a large number of static strings? I have tried creating a new package for UWP with the problematic icon packs using the same path data, but it still triggers the error stated above. But when I put the data inside a sqlite database and read from that, the error does not show and it compiles and runs successfully when using .NET Native.

from mahapps.metro.iconpacks.

timunie avatar timunie commented on June 8, 2024

Interesting finding. Do you think source generators may be helpful in that case?

from mahapps.metro.iconpacks.

MarkIvanDev avatar MarkIvanDev commented on June 8, 2024

Interesting finding. Do you think source generators may be helpful in that case?

If the source generators will only generate the same classes with the same static strings as data, I don't think it will make a difference. But I think if the path data will be put in resource files (.resx), I think we can work around the static string length limitation

from mahapps.metro.iconpacks.

timunie avatar timunie commented on June 8, 2024

No, the idea was to generate the PathGeometry directly.

from mahapps.metro.iconpacks.

MarkIvanDev avatar MarkIvanDev commented on June 8, 2024

@MarkIvanDev I will try and look if the resx can help here.

If there is anything I can help with, I'd love to.

from mahapps.metro.iconpacks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.