GithubHelp home page GithubHelp logo

Comments (5)

WeshGuillaume avatar WeshGuillaume commented on May 27, 2024

Hey @laurent-dol !

The client throws MailjetExcpetions for mostly internals excpetions.
But I dont think it ignore some errors by printing them. What is your code?

from mailjet-apiv3-java.

laurent-treeb avatar laurent-treeb commented on May 27, 2024

If you look at AbstractHttpClient.execute (called by post, get, ...) , exceptions are stored in a requestHandler. In case of BasicHttpClient, the requestHandler used is BasicRequestHandler that prints errors in console.

from mailjet-apiv3-java.

WeshGuillaume avatar WeshGuillaume commented on May 27, 2024

What about being able to provide a custom Handler to the MailjetClient's constructor ?
like : #58

from mailjet-apiv3-java.

laurent-treeb avatar laurent-treeb commented on May 27, 2024

My need goes further than exception management.

I'm writing a MailjetClient based on Apache HttpClient and not turbomanage, in order to manage connections pool, exception management, retries,...

To do this, I have only to modify MailjetRequest to get _filters outside of the package. (If a getFilter is added, it could be great).

Also, the Mailjet API should be modified to invite to do own implements. The first thing should be to add a MailjetClientInterface that i could implement with my own http client.
I purpose to modify MailjetException too, in order to add in the constructor the origin exception, so all methods of MailjetClient interface throw only MailjetException.

from mailjet-apiv3-java.

WeshGuillaume avatar WeshGuillaume commented on May 27, 2024

Hey ! I am closing it for now as the wrapper re-implementation is not on the roadmap yet.

from mailjet-apiv3-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.