high CPU usage about beacon

[gdanov]

I started seeing this once I began working on js project and by monitoring the timer list I figured out beacon mode causes emacs to constantly use 10-13% cpu on quad core mac. Not sure how connected the switch to js was.

profiling did not help me, but list-timers showed growing (10 or more) list of beacon timers even when I had only handful open files. once killed, emacs is smooth again and idle cpu usage is neglectable.

what I noticed when profiling was that the CPU spent 80% of the cycles in GC. Not sure how true this was and if it is connected to this issue.

[Malabarba]

A just pushed a commit that might resolve this. Could you test it again once Melpa rebuilds?

I admit it's a bit of a long shot though. Looking at the code, beacon should never have more than one active timer (in fact, it will generally have no timers). But maybe I missed something.

[gdanov]

updated ~1h ago, enabled beacon and so far looks very good. zero timers visible, cpu idling.

thanks!

[tpapp]

I have been testing it today and it looks fine so far, will give it a few days and then report back (for me the bug was somewhat occasional, so I want to make sure that this is the fix).

[Knusper]

I also had the issue with high CPU issue with an older version, but since having installed 20190104.1931 from melpa I do not experience the issue anymore.

[tpapp]

Sorry that I forgot to report back on this. Although the high CPU usage issue was resolved, I am still seeing a spike in CPU whenever I switch frames and see the beacon-mode animation, so I stopped using the package. But as far as I am concerned, the original issue can be closed.