GithubHelp home page GithubHelp logo

Comments (6)

malchata avatar malchata commented on May 25, 2024

Do these images reappear if you scroll or otherwise interact with the page after hitting the back button? In any event, I'll need a minimally reproducible test page (or pages in this case) to see the effect in action.

from yall.js.

Badhumvee avatar Badhumvee commented on May 25, 2024

https://docs.google.com/document/d/1gIxTtMXDW4ggoIJ-Ts1y33zlLX-ZeiCVg0EjbQszyFQ/edit?usp=sharing

Once you open that URL page in Chrome, we load a bunch of images using yall with the following settings:

       document.addEventListener("DOMContentLoaded", function() {
           yall({
               observeChanges: true,
               idlyLoad: true,
               threshold: 600
           });
       });

Then, just click on Sign-up on the top right corner.
Then click on the browser back button. At this point, we do not see any of the images we saw before.

I dont feel like it has anything to do with the idlyLoad issue.

Thanks for your help.

from yall.js.

malchata avatar malchata commented on May 25, 2024

Try dropping the attached version in to see if this helps:
yall-2.2.1.min.js.zip

I need to test this more in other browsers, but when I use local sources in Chrome to test this on a local version of your site, it appears to work. It adds the subtree option in the MutationObserver option, which is what I think fixes this issue.

from yall.js.

Badhumvee avatar Badhumvee commented on May 25, 2024

Hi malchata, Thanks for the updated file. I tried it locally, and it seems to fix this issue. I expect it will be fine when deployed. Will let you know if we see any issues. Thanks again.

from yall.js.

malchata avatar malchata commented on May 25, 2024

from yall.js.

malchata avatar malchata commented on May 25, 2024

Officially fixed and released as version 2.2.1.

from yall.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.