Unclear support for template names with dots or hyphens about chameleon

[malthe]

It does not require them to be valid, but yes, it does make the
interpreter throw a warning – and should be fixed of course.

I think there's two options:

1. Replace with underscore
2. Don't include template name in cache filename

It's convenient in debug-mode to have the filename in there, but maybe
it could be an option, or connected to the CHAMELEON_DEBUG flag.

\malthe

On 16 July 2011 20:16, hannosch
[email protected]
wrote:

The old zope.pagetemplate implementation supports arbitrary filenames for templates. It looks like Chameleon requires them to be valid Python module names.

I noticed this with a template named "manage-dashboard.pt", overridden via z3c.jbot in a Plone context. While loading that template with the template cache being enabled, I get an error message on the console:

   /template_cache/plone.app.portlets.browser.templates.manage-dashboard_d7c6cb77a0fc8e04ef7c535b94fb9cd64a795443.py:44:
   RuntimeWarning: Parent module 'plone.app.portlets.browser.templates' not found while handling absolute import
   import functools

It looks to me like the chameleon.template.BaseTemplateFile._cook method could do some quoting here. In the snippet:

   def cook(self, body, digest):
       filename = os.path.basename(self.filename)
       base, ext = os.path.splitext(filename)
       name = "%s%s.py" % (base, digest)
       cooked = self.loader.get(name)
       ...

it could quote the base part. I guess both dots and hyphens are problematic. Maybe replacing both of these with underscores would be simple enough.

Reply to this email directly or view it on GitHub:
#17

[hannosch]

I think having the filename in there is indeed useful. So simply replacing any non-alphanumeric, non-underscore character with an underscore might be good enough.

[malthe]

Fixed in f8fba42.