Unable to save filter with the same name and different type about manageiq-ui-classic

[hstastna]

@miq-bot add_label ui, question

[hstastna]

@dclarizio @h-kataria could you please look at this issue? Thank you!

[h-kataria]

There are some issues regarding saving filters in Advanced Search:

Let's load an existing default filter (type "default") under Global Filters.
Then if we want to save the filter with the same name as a filter which is not global (in My Filters; "Global search" unchecked before saving), it allows us to save a filter normally and the new filter appears under My Filters.
If we click on "Save" button again, it allows us to save the same filter again, but no more filters with the name appear in the tree.
It looks like the existing filter was just edited and saved.
BUT when we were creating a new filter, we were clicking on the same button, on "Save".
It is not always clear if we create a new filter or if we edit the existing one. Or is it a bug?

If user tries to save a filter with an existing name it edits the filter and Creates a new one if no filter is found with the given name

Let's create and save a new global filter in Advanced Search (expression editor).
Let's use the filter (load).
Then if we want to save the filter with the same name as a filter which is not global (in My Filters; "Global search" unchecked before saving, it throws an error "Name has already been taken", even if we have nothing under My Filters.

MiqSearch has validates uniquenes of Name with scope as db, so in this case value of name and db of the user created global filter and non-global filter are not unique, which is why you are seeing "Name has already been taken" flash message on screen. if you look in miq_searches table in db, value of name column is prefixed by "default_"/"Global_"/"user_" depending upon what type of filter is being saved making it unique.

I think Search is working as designed. I hope this answers your questions, let me know if you have further questions

[hstastna]

Thank you very much for the comment, Harpreet! It was very useful.