GithubHelp home page GithubHelp logo

UX - container image -> containers and container_pods screens have string truncation making it unusable about manageiq-ui-classic HOT 9 CLOSED

jrafanie avatar jrafanie commented on June 18, 2024 1
UX - container image -> containers and container_pods screens have string truncation making it unusable

from manageiq-ui-classic.

Comments (9)

jeffibm avatar jeffibm commented on June 18, 2024 1

@jeffibm this is actually image -> container or image -> container_pods as it's actually the pod name that is truncated so I can't really tell if it's resolved from the screenshot.

Truncation is fine but it should match the width of the column. If a use sees a truncating UI screen, they should be able to expand the column width to remove most if not all of the truncation.

In both screenshots, we're truncating well before the column width. How does it determine the text length before the truncation? We're either putting it in an element that doesn't match the column width or it's truncating based on a specific string length.

we used to truncate the text if its length is more than 40. let me put in some screenshots here with different possibilities.

from manageiq-ui-classic.

jrafanie avatar jrafanie commented on June 18, 2024 1

we used to truncate the text if its length is more than 40. let me put in some screenshots here with different possibilities.

Ok, I think that fails with different devices such as tablets or wide screen monitors so it's not really good for responsive design.

from manageiq-ui-classic.

jeffibm avatar jeffibm commented on June 18, 2024 1

If needed, we should get UX review on it for carbon to see if there are responsive features we're not using.

I didn't find any reference for truncation for table cells. the current implementation uses custom css.
The carbon data tables do have the option to expand rows, like an accordion. I was also thinking of making use of it for truncated text.. need to see how it would render truncated and non-truncated text.

from manageiq-ui-classic.

jeffibm avatar jeffibm commented on June 18, 2024 1

Closing this issue since the Fix was merged.

from manageiq-ui-classic.

jeffibm avatar jeffibm commented on June 18, 2024

Hey @jrafanie , will this presentation be ok?

image

To view this change, all we need to do is to pass a value truncateText=false to the StaticGTLView component (common component), which will remove the truncation of text on its data-table cells.

It was introduced a while ago to handle longer text to avoid horizontal scrolling and limit the table content to the screen width itself (which is not helpful in this page though)

Do we want to make this change based on modelName, in this case 'containers'?
like, do not truncate cells for certain pages.

from manageiq-ui-classic.

jrafanie avatar jrafanie commented on June 18, 2024

@jeffibm this is actually image -> container or image -> container_pods as it's actually the pod name that is truncated so I can't really tell if it's resolved from the screenshot.

Truncation is fine but it should match the width of the column. If a use sees a truncating UI screen, they should be able to expand the column width to remove most if not all of the truncation.

In both screenshots, we're truncating well before the column width. How does it determine the text length before the truncation? We're either putting it in an element that doesn't match the column width or it's truncating based on a specific string length.

from manageiq-ui-classic.

jrafanie avatar jrafanie commented on June 18, 2024

If needed, we should get UX review on it for carbon to see if there are responsive features we're not using.

from manageiq-ui-classic.

jeffibm avatar jeffibm commented on June 18, 2024

I modified the MiqDataTable a bit to look like this.
#8825

image image image image

from manageiq-ui-classic.

miq-bot avatar miq-bot commented on June 18, 2024

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

from manageiq-ui-classic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.