GithubHelp home page GithubHelp logo

Comments (5)

lgarrison avatar lgarrison commented on June 10, 2024

I think this is probably a case of self-counts being included in bins that have a minimum separation of 0 (which is the expected behavior although a little surprising sometimes). It's there to ensure that auto- and cross-correlations yield the same answer. For your case, I think you probably want to subtract off the self-count in the first bin; that is, subtract N from DDtheta.

from corrfunc.

ub2206 avatar ub2206 commented on June 10, 2024

Thanks a lot for the response and sorry for the late reply from my side. I would just like to confirm just one thing (in case if I am doing anything wrong).

The N is supposed to be subtracted from the npairs of the auto-correlation term only, am I right? The cross-correlation term should be left as it is.

from corrfunc.

lgarrison avatar lgarrison commented on June 10, 2024

That's right, it won't make a difference for cross-correlations. You may also need to subtract it from the RR term if that's computed with pair counts.

from corrfunc.

ub2206 avatar ub2206 commented on June 10, 2024

Thanks a lot for the solutions. The results are much more accurate and explainable now.

from corrfunc.

manodeep avatar manodeep commented on June 10, 2024

Thanks @lgarrison!

@ub2206 While your issue itself is resolved, since you are effectively computing angular correlation functions over half the sky - it might be worthwhile to check if the runtime improves if you set both link_in_ra and link_in_dec to False.

from corrfunc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.