Creating a new client with fully qualified strategy class name takes too long about manticoresearch-php

[adriannuta]

The class instance can be passed instead of the class name (like 'connectionStrategy' => new \Manticoresearch\Connection\Strategy\StaticRoundRobin()).

Removing the class_exists or disabling the autoload I don't think are good ideas. Instead at

manticoresearch-php/src/Manticoresearch/Client.php

Line 83 in cdbd495

if (class_exists($strategyName)) {

it might make sense to test if the class name starts with Manticoresearch\ (like 0 === strncmp($className, 'Manticoresearch\\', 16))

[githubmanticore]

➤ Nick Sergeev commented:

I've run both variants, but actually haven't observed a noticeable difference in performance.

Here is my test script test_time.php

<?php 
 
require_once  __DIR__ . '/vendor/autoload.php'; 
$config_connections = [ 
    [ 
        'host' => 'localhost', 
        'port' => '9308', 
    ], 
]; 
$client = new \Manticoresearch\Client([ 
    'connections' => $config_connections, 
    'connectionStrategy' => 'StaticRoundRobin',  // variant 1 
    //'connectionStrategy' => \Manticoresearch\Connection\Strategy\StaticRoundRobin::class, // variant 2 
    'retries' => 3 
]); 
 
?> 

And here is an example of the performance times obtained with time php test_time.php for the variants 1 and 2, respectively:

real	0m0,042s 
user	0m0,031s 
sys	0m0,009s 

and

real	0m0,042s 
user	0m0,025s 
sys	0m0,009s 

[markomilivojevic]

The difference cannot be noticed with very few php classes in a project, but when you have thousands of classes it is noticeable. It rebuilds autoload for all classes in a project.

[githubmanticore]

➤ Nick Sergeev commented:

Ok, as it was proposed above, we updated the client to skip the class_exists check if the path to a strategy class starts with Manticoresearch\