Comments (8)
Interesting. I agree that the API should behave consistently here. Fancy looking into it and sending a patch?
from mochify.js.
Not so much, but here are some more details.
To handle errors properly (gulp return !=0 on test failure, or, on any other failure) I had to register two calbacks. When the error reason is test failure, then both of the callbacks are called causing a warning in gulp. Not a blocker and node/phantom/webdriver consistent.
Using webdriver, I could not find a callback that's triggered after the tests hence the gulp task marked as finished too soon. Finding a way would provide a workaround. Any clue?
Did you reproduce the described behaviours using the sample project?
from mochify.js.
Sorry, but I have no time / motivation in fixing issues that arise from this use case. I will assist, merge and release a patch if anyone volunteers.
from mochify.js.
No problem. I can put some cycles trying to understand at first.
Writing helps. I reviewed my sample project and removed xunit reporter and reports collection. This has nothing to do with this issue. Moreover, I was wrong about error handling, a single callback is enough. Sorry for the noise.
I now suppose that when using webdriver the bundle() method returns something (stream,promise?) that ends prematurely. Does that makes any sense to you?
from mochify.js.
Sure, makes sense. What is returned by Mochify is the Browserify instance with an "enriched" pipeline. The plugin that gets added into the pipeline for webdriver tests is min-webdriver. Maybe you can find something in there.
from mochify.js.
Thanks for the pointers Maximilian. I had the same feeling, the culprit seems to be in min-webdriver.
Unfortunately I'm not up to speed when it comes with the js ecosystem and don't have much free cycles myself.
At least the issue is documented now.
from mochify.js.
There was some refactoring lately regarding error handling and also in the webdriver module. This might have fixed the issue. @eskatos Can you check, please?
from mochify.js.
Hey @mantoni, thanks for the feedback.
Unfortunately, for various reasons, I switched to other tools for the concerned project so won't be able to check.
from mochify.js.
Related Issues (20)
- Async test cases that fail end the entire test suite HOT 2
- Mochify does not work on Browserstack with Safari 12 or Firefox 64 HOT 10
- uncaught errors should be printed to stderr, not stdout HOT 6
- Support Puppeteer for Firefox HOT 6
- Support `--dumpio` option for tracing down errors with chromium
- Pass flags to Browserify HOT 3
- Update to a more recent version of mocha HOT 9
- Use Browserify 17 HOT 1
- Mochify Rewrite HOT 14
- `window._webdriver_manualPoll is not a function` on BrowserStack since 8.0.0 HOT 1
- Rewrite: Puppeteer settings HOT 1
- Rewrite: Integration tests for WebDriver
- Rewrite: Implement watch mode HOT 7
- Rewrite: Allow "external" mochify drivers
- Rewrite: Support native JavaScript modules HOT 2
- Rewrite: Release & publishing strategy HOT 11
- Rewrite: v1.0.0
- Rewrite: nested configuration does not get merged correctly
- Rewrite: Documentation HOT 1
- Rewrite: read spec/bundle from stdin HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mochify.js.