Comments (8)
@manzinello No problem, I will check this.
from mailgo.
I would be willing to work on this and submit a PR. For example I could start writing some unit tests for the mailgoDirectRender and mailgoValidateEmail functions, using Typescript and the React Testing Library.
I think that it is a very important point, thank you!
Would this be a welcome addition?
Absolutely yes! Proceed with the PR when you want, thank you so much!
from mailgo.
Ok, I will start looking into this. Thanks.
from mailgo.
Hi @gianantoniopini, it seems that there is something that isn't working properly with tests (window and document). I've just updated the dependencies. I'm sorry and I can't work on this at the moment, can you help me? https://github.com/manzinello/mailgo/actions/runs/895410024 Otherwise I will go in depth with this problem as soon as I can. Thank you so much
from mailgo.
Thank you so much!
from mailgo.
The issue was related to the update of Jest to version 27. In this new version of Jest the default test environment has been changed from "jsdom" to "node". See this https://jestjs.io/blog/2021/05/25/jest-27#flipping-defaults .
We were affected by this change because we use the DOM APIs and did not have the test environment explicitly configured. So I have configured "testEnvironment": "jsdom" in the jest.config.js file.
I will create a PR for this change.
from mailgo.
Thank you!
from mailgo.
You are welcome :-)
from mailgo.
Related Issues (20)
- Does not work with empty recipient field HOT 1
- Custom actions? HOT 7
- Export of validateEmail function HOT 7
- Run unit tests automatically on each push or pull request HOT 2
- Custom action displayed even with `actions.custom` set to false. HOT 24
- Add unit tests around configuration
- Error when using mailgoDirectRender HOT 2
- Custom Actions with Tel Not Displayed HOT 1
- Set Tel Title HOT 1
- responsive setting HOT 3
- Vue/Buefy mailgo doesn't work in production. HOT 3
- Question: hide body and subject in modal HOT 14
- Doesn't work in links inside dynamically created elements HOT 3
- Tel links with extensions HOT 3
- mailgo modal doesn't open when clicking on telephone like if you exclude a telephone action e.g. whatsapp using window.mailgoConfig HOT 2
- Subject line opens up in 'to' address in gmail / direct render HOT 4
- Clicking the 'copy' button only copies the 'to' address. HOT 6
- Dark theme is not supported with direct render. HOT 8
- Passing a dictionary with configuration options to the direct renderer had no affect when using direct render. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mailgo.