Drawing a LineString prematurely completes final double tap on touch devices about mapbox-gl-draw

[jaybo]

I tried adding the following tap debounce code to draw_line_string.js and it seems to have completely solved the problem:

DrawLineString.lastTapTime = Date.now();

DrawLineString.onTap = function (state, e) {
  const now = Date.now();
  const tapDebounceTimeMS = 300;
  if (now - this.lastTapTime < tapDebounceTimeMS) {
    return;
  }
  this.lastTapTime = now;
  if (CommonSelectors.isVertex(e)) return this.clickOnVertex(state, e);
  this.clickAnywhere(state, e);
};

To get tests to run, I had to add a 400mS delay immediately before every instance of touchTap(...) in draw_line_string.test.js. I'm sure my naive sleep() below isn't the best solution, but I don't really understand how to best implement such a delay within the testing framework:

const tapDebounceDelayMS = 400;

function sleep(milliseconds) {
  const date = Date.now();
  let currentDate = null;
  do {
    currentDate = Date.now();
  } while (currentDate - date < milliseconds);
}

Used like:

      sleep(tapDebounceDelayMS);
      touchTap(map, makeTouchEvent(100, 200));

Although I didn't try it, all of the Polygon code should have the same treatment.