GithubHelp home page GithubHelp logo

Comments (2)

ianformanek avatar ianformanek commented on September 5, 2024 1

Technically, the map is never idle when you pass repaint: true to options. Can you add more context on why you need to set that option to true? We exposed this option in v3.4, that's why it "works" in older versions (because this option has no effect).

This is a good point, indeed the repaint: true is causing the issue starting 3.4.

The repaint: true in our case comes from a long time ago, when our mapbox-gl version was 0.23.0. It seems the repaint property back then was used for something different (this PR is one of the few things I found from that time) and we probably used it to work around some issues with updating data on existing map instance.

With the new semantics, it might be safer to name the property with a distinct/unique name (debugContinuousRepaint), but our ancient leftover is probably not a strong enough trigger for this, so just a minor suggestion.

In any case, we will remove the repaint: true which is all that is needed for our case, thanks for the quick help!

from mapbox-gl-js.

mourner avatar mourner commented on September 5, 2024

Technically, the map is never idle when you pass repaint: true to options. Can you add more context on why you need to set that option to true? We exposed this option in v3.4, that's why it "works" in older versions (because this option has no effect).

from mapbox-gl-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.