GithubHelp home page GithubHelp logo

Comments (11)

edenh avatar edenh commented on May 15, 2024

ref mapbox/mapbox-gl-js#659

from mapbox-gl-styles.

wboykinm avatar wboykinm commented on May 15, 2024

SO EXCITING.

from mapbox-gl-styles.

nickidlugash avatar nickidlugash commented on May 15, 2024

@peterqliu Did you ever start on this style?

from mapbox-gl-styles.

peterqliu avatar peterqliu commented on May 15, 2024

@nickidlugash y, progress has been stored on a bite, but I think @edenh said someone else wanted to work on it (Ian maybe?), so it got passed off to him. My bad for not updating-- didn't know this ticket existed til now!

from mapbox-gl-styles.

nickidlugash avatar nickidlugash commented on May 15, 2024

@peterqliu thanks for the update. Is there any reason why this style can't be in a branch of this repo? Would it be possible to move it?

There's been some demand for this, so we should figure out who's on it!

from mapbox-gl-styles.

peterqliu avatar peterqliu commented on May 15, 2024

@nickidlugash oh scratch that-- it's actually sitting on the satellite branch in gl-custom-styles. Feel free to take if you'd like to jump on it now-- otherwise I will tackle it once I wrap up Turf tomorrow.

from mapbox-gl-styles.

peterqliu avatar peterqliu commented on May 15, 2024

Picked up where I left off a few months back, updated to the latest version of GL, and added some polish. This style is going to keep labels informative but at a minimum, to defer to the satellite imagery.

screen shot 2015-01-23 at 4 55 18 pm

screen shot 2015-01-23 at 4 56 02 pm

screen shot 2015-01-23 at 5 03 03 pm

Most of my to-dos have been tackled, though I do want to wait for the v7 dasharrays before wrapping this up. In the meantime, all feedback would be welcome.

cc @andreasviglakis @nickidlugash

from mapbox-gl-styles.

jfirebaugh avatar jfirebaugh commented on May 15, 2024

@peterqliu Can you move it over to this repository as satellite-labels-v7.json in the v7 branch? You can test against mapbox-gl-js master, which has the new dasharray support.

from mapbox-gl-styles.

peterqliu avatar peterqliu commented on May 15, 2024

Yup, the style is now tracked at https://github.com/mapbox/mapbox-gl-styles/blob/v7/styles/satellite-labels-v7.json

Per chat with @jfirebaugh , we've found it made more sense to have one style for satellite imagery, with labels and contour lines toggle-able via separate classes. I will delete the current satellite style, and use this one for both purposes.

from mapbox-gl-styles.

ljbade avatar ljbade commented on May 15, 2024

@peterqliu toggleable labels sounds great.

from mapbox-gl-styles.

peterqliu avatar peterqliu commented on May 15, 2024

Alrighty, satellite-labels-v7 is now satellite-v7, and the old satellite-v7 is gone. Style lives here, will go live once v7 merges.

@ljbade use classes labels and contours to dial up the respective labeling.

from mapbox-gl-styles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.