remove or improve water texture about mapbox-gl-styles

[andreasviglakis]

yes, also this on my 6+

[friedbunny]

@andreasviglakis Those both look like rendering bugs on native. I haven't seen the Emerald blocky-border issue come up, but the Bright problem seems like mapbox/mapbox-gl-native/issues/1051

[nickidlugash]

hmm I saw the same rendering issue as @andreasviglakis on my iPhone5 at some point yesterday morning, but then it suddenly went away.

@peterqliu personally, I think removing the water pattern might make the most sense, given that this map is both general-purpose and very road-focused. I find it sometimes competes with actual line geometries, like minor roads.

[1ec5]

If we remove the water pattern, would it be possible to darken or lighten the edges of bodies of water, to make them stand out more?

[nickidlugash]

@1ec5 no really good way, atm. Strokes are ok, but problematic at low zooms, and add a "glow" effect (most common way of adding contrast in carto) is not implemented yet.

[jfirebaugh]

This could be mapbox/mapbox-gl-native#1038. Let's see if it's fixed by mapbox/mapbox-gl-native@2492279.

[ansis]

This is not mapbox/mapbox-gl-native#1038 but I'm looking into what it is.

[ansis]

https://github.com/mapbox/mapbox-gl-native/tree/fix-sprite-padding should fix @andreasviglakis's bug.

It doesn't fix @samanpwbb's original style issue.

mapbox/mapbox-gl-js#1125 might help later, but not yet.

[peterqliu]

removed water pattern