Comments (6)
Named needs to be named - modestmaps looks for .name
as a property, and as such it can't be a function without very dangerous code, or a modestmaps tweak.
renderer could be valid, though it does refer to the factory pattern
markers.features refers to the features
member of a GeoJSON feature collection, and markers.js aims to continue to support GeoJSON type objects internally, even if it supports other 'converters' to/from that format. data
also could be confused with the data
member in TileJSON.
addCallback
and removeCallback
are made to mirror modestmaps; I'd rather keep these continuous; they mirror addEventlistener in HTML and have been established for a while.
Hide on move, sure, works for me.
Template - no; this isn't templating, really: it doesn't take a template as an argument.
easey.toPoint I'd rather not use Point because it could be easily confused with MM.Point, which this has nothing to do with. open to other namings though
from mapbox.js.
- Perhaps
setPosition
? instead of toPoint ? - I know factory refers to the factory pattern but I feel like an api shouldn't bear its name - internally yes but not outwardly. the word, "render" attributes more closely to what it does I think.
from mapbox.js.
render
is also a verb; you would expect markers.render()
to render the markers. it would have to be markers.renderer()
right?
from mapbox.js.
Ah I see. Yes, renderer
from mapbox.js.
Technically it's like an x
value in http://en.wikipedia.org/wiki/Interpolation . Position is also kind of an overloaded term; unless we can find something that's accurate and specific, I don't really want to change this (plus it's a pro feature anyway)
from mapbox.js.
We're supporting camelCase in v1 and such.
from mapbox.js.
Related Issues (20)
- Update to new Maki icons HOT 1
- Coordinate error HOT 1
- Cesium 3DTiles can be supported in mapbox-gl?
- Document that `null` style URL is necessary when using a styleLayer and passing map options
- Zooming in on map breaks isochrone HOT 1
- Static Tiles API 403 Error on Chrome HOT 2
- [Docs] Broken link to L.Mapbox.Template HOT 2
- OffscreenCanvas HOT 2
- How can I draw rectangle with MapBox around coordinate HOT 1
- setLngLat on marker doesn't work HOT 2
- Getting error Cannot read properties of null (reading 'geometry') HOT 1
- Map not loading properly
- Static API returns invalid geojson with MultiPolygon HOT 1
- How to add multiple map marker HOT 1
- request fixed/patching vulnerable CVE-2020-8203
- geocode returns leading zero stripped postCode
- How to have black theme in react not finding any resource for react
- Mapbox Popup Marker Not Working on Mobile
- Satellite layer map issue
- mapbox-address-autofill component too aggressive with css injection in shadow root HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mapbox.js.