Comments (5)
If we ifdef
the MBTiles solution and anything resulting from it, we should also ifdef
the header documentation, otherwise we're going to get compile-time warnings with undefined methods anyway.
from mbxmapkit.
Sorry, to be clear: anything in the API should be documented, but if we are using ifdef
for things, the docs should toggle similarly. This will get picked up by things like local runs of appledoc
or the use of CocoaPods, which I think will require us to use subspecs for these various optional features.
from mbxmapkit.
Yeah, the doc comments I added to the header are inside the ifdef so if I'm understanding you correctly, I don't think that will be a problem.
My point was a little bit more along the lines of whether you want to remove the ifdef around MBXMapViewTileOverlay (i.e. de-couple it from the MBTiles stuff) [edit: I could have been a bit more clear about that]. That's necessary for #7 and anything else where somebody wants to hit MKTileOverlay properties from a view controller. The present arrangement (no MBXMapViewTileOverlay in the header) is hiding/breaking part of the MKMapKit api.
from mbxmapkit.
My point was a little bit more along the lines of whether you want to remove the ifdef around MBXMapViewTileOverlay (i.e. de-couple it from the MBTiles stuff). That's necessary for #7 and anything else where ...
Ok. We should probably either decide for/against that in the #3 MBTiles solution itself (on deck: #20) or break it into a separate issue ("expose MBXMapViewTileOverlay
to public API because $reasons
"), at which point we'd document it there. That lets us decide the merits of doing that change on its own terms and lets us iterate first on the MBTiles feature, then on a new API feature.
from mbxmapkit.
Okay cool, let's just worry about that later. There are enough hints in all these issues that anybody who cares badly enough should be able to figure out how to make it work for now.
from mbxmapkit.
Related Issues (20)
- MKOverlayRenderer setNeedsDisplayInMapRect:zoomScale: HOT 6
- [VKTileKeyMap enumerateKeysAndObjectsUsingBlock:] HOT 16
- how to grant app to use my api access token? HOT 1
- React Native Module HOT 1
- BSD license HOT 4
- warning in new Xcode on canReplaceMapContent
- mbx_zoomLevel might return the wrong zoom level
- MBXMapKitErrorCodeOfflineMapSqlite to delegate
- MBXMapKit Example App high CPU usage HOT 7
- Crashes in [VKRasterOverlayTileSource invalidateRect:level:] and [VKTileKeyMap enumerateKeysAndObjectsUsingBlock:] HOT 2
- MBXOfflineMapDownloader suspend/resume sequence and activeDataSessionTasks count HOT 3
- Redundant tile loads in MBXRasterTileRenderer canDrawMapRect: when using 512px tiles HOT 6
- Swift: MGLMultiPoint should use Int for pointCount HOT 3
- Remove `example.mapids` and make sure offline works
- deprecate repo in favor of GL HOT 8
- random crashes coming from MBXMapKit/VectorKit HOT 1
- Is 0.8.0 / v4 API backwards compatible? HOT 1
- MapID problem? HOT 1
- Remove mb-pages branch HOT 1
- IOS SDK Cluster effect
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mbxmapkit.