GithubHelp home page GithubHelp logo

Comments (5)

incanus avatar incanus commented on June 18, 2024

If we ifdef the MBTiles solution and anything resulting from it, we should also ifdef the header documentation, otherwise we're going to get compile-time warnings with undefined methods anyway.

from mbxmapkit.

incanus avatar incanus commented on June 18, 2024

Sorry, to be clear: anything in the API should be documented, but if we are using ifdef for things, the docs should toggle similarly. This will get picked up by things like local runs of appledoc or the use of CocoaPods, which I think will require us to use subspecs for these various optional features.

from mbxmapkit.

 avatar commented on June 18, 2024

Yeah, the doc comments I added to the header are inside the ifdef so if I'm understanding you correctly, I don't think that will be a problem.

My point was a little bit more along the lines of whether you want to remove the ifdef around MBXMapViewTileOverlay (i.e. de-couple it from the MBTiles stuff) [edit: I could have been a bit more clear about that]. That's necessary for #7 and anything else where somebody wants to hit MKTileOverlay properties from a view controller. The present arrangement (no MBXMapViewTileOverlay in the header) is hiding/breaking part of the MKMapKit api.

from mbxmapkit.

incanus avatar incanus commented on June 18, 2024

My point was a little bit more along the lines of whether you want to remove the ifdef around MBXMapViewTileOverlay (i.e. de-couple it from the MBTiles stuff). That's necessary for #7 and anything else where ...

Ok. We should probably either decide for/against that in the #3 MBTiles solution itself (on deck: #20) or break it into a separate issue ("expose MBXMapViewTileOverlay to public API because $reasons"), at which point we'd document it there. That lets us decide the merits of doing that change on its own terms and lets us iterate first on the MBTiles feature, then on a new API feature.

from mbxmapkit.

 avatar commented on June 18, 2024

Okay cool, let's just worry about that later. There are enough hints in all these issues that anybody who cares badly enough should be able to figure out how to make it work for now.

from mbxmapkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.