GithubHelp home page GithubHelp logo

Comments (8)

mathisloge avatar mathisloge commented on June 25, 2024 1

Hey @artemp
let me find some time this week to look into this and #4439
I'll check it with https://github.com/mapnik/gh-actions-test since there the debug upload of vcpkg is active.

from mapnik.

mathisloge avatar mathisloge commented on June 25, 2024 1

matrix.static-build == 'OFF' implies BUILD_SHARED_LIBS=OFF ?

yes

so everything will be build as static which implies BUILD_SHARED_PLUGINS=OFF

from mapnik.

mathisloge avatar mathisloge commented on June 25, 2024 1

The build failures are actually a cmake bug which will get fixed in 3.29.2
https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9420

So we just have to wait for actions/runner-images#9685

from mapnik.

mathisloge avatar mathisloge commented on June 25, 2024 1

I think it's a good opportunity to drop c++14.
At least then some boost dependencies could be dropped like optional and the filesystem

from mapnik.

artemp avatar artemp commented on June 25, 2024

There is also seems inconsistency in build_and_test.yml with

-DBUILD_SHARED_LIBS:BOOL=${{ matrix.static-build || 'ON' }} \

matrix.static-build == 'OFF' implies BUILD_SHARED_LIBS=OFF ?
@mathisloge

from mapnik.

mathisloge avatar mathisloge commented on June 25, 2024

@artemp is the c++14 support for v4 still planned? Or will it be min. c++17?

from mapnik.

artemp avatar artemp commented on June 25, 2024

@mathisloge I'm personally ok to drop c++14, make c++20 default for any packaging but support still c++17 for the time being. Unless there are some good reasons?

from mapnik.

mathisloge avatar mathisloge commented on June 25, 2024

Now the runners are all running again. I think we can close this :)

from mapnik.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.