GithubHelp home page GithubHelp logo

Comments (3)

mkrumpholz avatar mkrumpholz commented on June 14, 2024

Yeah, this should be implemented to see the errors earlier. Now the error is visible at compile time. This is OK but it could be visible earlier, just do the same checks and add an error highlighter. IDEA runs the implemented checks in the background. :)

from mapstruct-idea.

filiphr avatar filiphr commented on June 14, 2024

@mkrumpholz we do have some checks and inspections.

What Gunnar was referring to (I think) is to get the warnings / errors from the compiler and not reimplement the same logic as we have in the Mapstruct code generator. I don't know much about the Eclipse plugin, but from what I've seen the Eclipse plugin uses the compiler output to show the error markers.

Do you have some ideas for how to achieve this @mkrumpholz?

from mapstruct-idea.

mkrumpholz avatar mkrumpholz commented on June 14, 2024

IntelliJ parses the code and builds the internal tree (PSI). I think you know that when you're on plugin development. The checks are part of that process and i would expect that you could have a bit more generic code as a module to use it in the code generator as well as in the code analysis in the IDEA plugin. And i think @gunnarmorling is talking about the error highlighting in IDEA that is not asking the java compiler for the errors but using its own checks.

from mapstruct-idea.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.